albertogpz commented on code in PR #970:
URL: https://github.com/apache/geode-native/pull/970#discussion_r917628356
##########
cppcache/include/geode/DataInput.hpp:
##########
@@ -502,21 +502,21 @@ class APACHE_GEODE_EXPORT DataInput {
inline char readPdxChar() { return static_cast<char>(readInt16()); }
- inline void _checkBufferSize(size_t size, int32_t line) {
- if ((m_bufLength - (m_buf - m_bufHead)) < size) {
+ virtual void _checkBufferSize(size_t size, int32_t line) {
Review Comment:
I am afraid it is necessary for the solution. But given that this will go in
a minor release I do not think it is an issue.
Is there a log file in place where I could add this change as proposed in:
https://lists.apache.org/thread/0v2r5trv926oj8qrgfp00467y3rycsvw
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
