[GitHub] [geode] kirklund commented on a diff in pull request #7571: GEODE-10327: Overhaul GfshRule to kill processes and save artifacts for failures

[GitBox]

kirklund commented on code in PR #7571:
URL: https://github.com/apache/geode/pull/7571#discussion_r878598310


##########
geode-assembly/src/acceptanceTest/java/org/apache/geode/ssl/CertificateRotationTest.java:
##########
@@ -339,16 +348,16 @@ private void startCluster() throws IOException, 
GeneralSecurityException {
         .sanIpAddress(InetAddress.getByName("127.0.0.1"))
         .generate();
 
-    clusterKeyStore = temporaryFolder.newFile("cluster-keystore.jks");
-    writeCertsToKeyStore(clusterKeyStore.toPath(), clusterCert);
+    clusterKeyStore = createFile(rootFolder.resolve("cluster-keystore.jks"));
+    writeCertsToKeyStore(clusterKeyStore, clusterCert);
 
-    clusterTrustStore = temporaryFolder.newFile("cluster-truststore.jks");
-    writeCertsToTrustStore(clusterTrustStore.toPath(), caCert);
+    clusterTrustStore = 
createFile(rootFolder.resolve("cluster-truststore.jks"));
+    writeCertsToTrustStore(clusterTrustStore, caCert);
 
-    clusterSecurityProperties = 
temporaryFolder.newFile("cluster-security.properties");
+    clusterSecurityProperties = 
createFile(rootFolder.resolve("cluster-security.properties"));
     Properties properties = CertStores.propertiesWith("all", "any", "any",
         clusterTrustStore, dummyStorePass, clusterKeyStore, dummyStorePass, 
true, true);
-    properties.store(new FileOutputStream(clusterSecurityProperties), "");
+    properties.store(new FileOutputStream(clusterSecurityProperties.toFile()), 
"");

Review Comment:
   Close file stream? Why does this one pass on Windows?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org