Bill commented on code in PR #7571:
URL: https://github.com/apache/geode/pull/7571#discussion_r879960279
##########
geode-junit/src/main/java/org/apache/geode/test/version/TestVersion.java:
##########
@@ -17,18 +17,24 @@
import java.io.Serializable;
import java.util.Objects;
+@SuppressWarnings("serial")
public class TestVersion implements Comparable<TestVersion>, Serializable {
- public static final TestVersion CURRENT_VERSION = new
TestVersion(VersionManager.CURRENT_VERSION);
+
+ static final TestVersion CURRENT_VERSION = new
TestVersion(VersionManager.CURRENT_VERSION);
private final int major;
private final int minor;
private final int release;
+ public static TestVersion current() {
+ return CURRENT_VERSION;
+ }
+
Review Comment:
It looks like this method was added to provide a little more encapsulation
than exposing `CURRENT_VERSION` did. Only `VmConfiguration` continues to
reference `CURRENT_VERSION`: I recommend making that class go through the
method so `CURRENT_VERSION` can become `privsate`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
