[GitHub] [geode] nabarunnag commented on a diff in pull request #7740: GEODE-10106: Use queueConnection snapshot for if

[GitBox]

nabarunnag commented on code in PR #7740:
URL: https://github.com/apache/geode/pull/7740#discussion_r887320991


##########
geode-core/src/main/java/org/apache/geode/cache/client/internal/QueueManagerImpl.java:
##########
@@ -862,8 +862,9 @@ public void recoverPrimary(Set<ServerLocation> 
excludedServers) {
       return;
     }
     final boolean isDebugEnabled = logger.isDebugEnabled();
-    if (queueConnections != null && queueConnections.getPrimary() != null
-        && !queueConnections.getPrimary().isDestroyed()) {
+    ConnectionList snapshot = queueConnections;

Review Comment:
   @pivotal-jbarrett I just cherry-pick the fix from another method in the same 
class. I will get it refactored



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org