pivotal-jbarrett commented on code in PR #7740:
URL: https://github.com/apache/geode/pull/7740#discussion_r887358938
##########
geode-core/src/main/java/org/apache/geode/cache/client/internal/QueueManagerImpl.java:
##########
@@ -966,6 +965,16 @@ public void recoverPrimary(Set<ServerLocation>
excludedServers) {
}
}
+ private boolean isPrimaryRecoveryNeeded(final ConnectionList
queueConnectionList) {
Review Comment:
If you make this static you could easily create unit tests that could test
all the paths in this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
