raboof commented on code in PR #7908:
URL: https://github.com/apache/geode/pull/7908#discussion_r2225746510
##########
geode-wan/src/test/java/org/apache/geode/cache/wan/internal/WanCopyRegionFunctionServiceTest.java:
##########
@@ -145,7 +145,7 @@ public void
cancelAllExecutionsWithRunningExecutionsReturnsCanceledExecutions()
});
// Wait for the functions to start execution
- await().untilAsserted(() ->
assertThat(service.getNumberOfCurrentExecutions()).isEqualTo(2));
+ await().untilAsserted(() ->
assertThat(service.getNumberOfCurrentExecutions()).isLessThanOrEqualTo(2));
Review Comment:
I think with this change the test would continue too quickly.
The goal of this line is to wait until the tasks have started.
`await().untilAsserted` repeatedly runs `() ->
assertThat(service.getNumberOfCurrentExecutions()).isEqualTo(2)` until it
succeeds (or times out).
Changing the assertion to `.isLessThanOrEqualTo(2)` would make the test
continue before both tasks have started, which I think is not what we want.
Do you see it time out? Perhaps we need to give it some more time before it
gives up waiting for both tasks to start?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
