marinov-code commented on code in PR #7908:
URL: https://github.com/apache/geode/pull/7908#discussion_r2225945741
##########
geode-wan/src/test/java/org/apache/geode/cache/wan/internal/WanCopyRegionFunctionServiceTest.java:
##########
@@ -145,7 +145,7 @@ public void
cancelAllExecutionsWithRunningExecutionsReturnsCanceledExecutions()
});
// Wait for the functions to start execution
- await().untilAsserted(() ->
assertThat(service.getNumberOfCurrentExecutions()).isEqualTo(2));
+ await().untilAsserted(() ->
assertThat(service.getNumberOfCurrentExecutions()).isLessThanOrEqualTo(2));
Review Comment:
Hi @raboof, thank you for your review. I agree, it's better to keep the
isEqualTo(). I pushed a new fix replacing the CompletableFuture.supplyAsync()
with fixed thread pool executor. CompletableFuture.supplyAsync() uses the
common ForkJoinPool, which may not have enough threads for all concurrent
executions which will cause
assertThat(service.getNumberOfCurrentExecutions()).isEqualTo(2) to timeout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
