raboof commented on code in PR #7907:
URL: https://github.com/apache/geode/pull/7907#discussion_r2303489149
##########
geode-core/src/test/java/org/apache/geode/internal/size/WellKnownClassSizerJUnitTest.java:
##########
@@ -52,7 +53,11 @@ public void testStrings() {
- ObjectSizer.SIZE_CLASS_ONCE.sizeof(new char[0]);
assertEquals(emptySize + roundup(OBJECT_SIZE + 4 + 3 * 2),
WellKnownClassSizer.sizeof(test1));
- assertEquals(emptySize + roundup(OBJECT_SIZE + 4 + 9 * 2),
WellKnownClassSizer.sizeof(test2));
+ if (SystemUtils.isAzulJVM()) {
+ assertEquals(emptySize + roundup(OBJECT_SIZE + 4 + 9 * 2 + 8),
WellKnownClassSizer.sizeof(test2));
+ } else {
+ assertEquals(emptySize + roundup(OBJECT_SIZE + 4 + 9 * 2),
WellKnownClassSizer.sizeof(test2));
+ }
Review Comment:
Do you have a motivation why azul needs the extra `+ 8`, or is that just
'trial and error'?
If it's just 'trial and error', I think I'd prefer:
```suggestion
if (!SystemUtils.isAzulJVM()) {
assertEquals(emptySize + roundup(OBJECT_SIZE + 4 + 9 * 2),
WellKnownClassSizer.sizeof(test2));
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
