JinwooHwang-SAS commented on code in PR #7907:
URL: https://github.com/apache/geode/pull/7907#discussion_r2303536444
##########
geode-core/src/test/java/org/apache/geode/internal/size/WellKnownClassSizerJUnitTest.java:
##########
@@ -52,7 +53,11 @@ public void testStrings() {
- ObjectSizer.SIZE_CLASS_ONCE.sizeof(new char[0]);
assertEquals(emptySize + roundup(OBJECT_SIZE + 4 + 3 * 2),
WellKnownClassSizer.sizeof(test1));
- assertEquals(emptySize + roundup(OBJECT_SIZE + 4 + 9 * 2),
WellKnownClassSizer.sizeof(test2));
+ if (SystemUtils.isAzulJVM()) {
+ assertEquals(emptySize + roundup(OBJECT_SIZE + 4 + 9 * 2 + 8),
WellKnownClassSizer.sizeof(test2));
+ } else {
+ assertEquals(emptySize + roundup(OBJECT_SIZE + 4 + 9 * 2),
WellKnownClassSizer.sizeof(test2));
+ }
Review Comment:
Thank you for your thoughtful insight and guidance, @raboof. I do not have a
clear technical justification for why Azul requires the additional + 8. I did
attempt to investigate the discrepancy, but was unable to determine the
underlying cause. I am happy to revise the code to follow your recommendation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
