jdaugherty commented on code in PR #14836:
URL: https://github.com/apache/grails-core/pull/14836#discussion_r2174062304
##########
.github/workflows/gradle.yml:
##########
@@ -215,9 +284,11 @@ jobs:
path: grails-gradle/build/grails-gradle-artifacts.txt
publish:
needs: [ publishGradle, build, functional, hibernate5Functional,
mongodbFunctional ]
- if: ${{ always() && github.repository_owner == 'apache' &&
github.event_name == 'push' && needs.publishGradle.result == 'success' &&
(needs.build.result == 'success' || needs.build.result == 'skipped') &&
(needs.functional.result == 'success' || needs.functional.result == 'skipped')
&& (needs.hibernate5Functional.result == 'success' ||
needs.hibernate5Functional.result == 'skipped') &&
(needs.mongodbFunctional.result == 'success' || needs.mongodbFunctional.result
== 'skipped') }}
+ if: ${{ always() && github.repository_owner == 'apache' &&
(github.event_name == 'push' || github.event_name == 'workflow_dispatch') &&
needs.publishGradle.result == 'success' && (needs.build.result == 'success' ||
needs.build.result == 'skipped') && (needs.functional.result == 'success' ||
needs.functional.result == 'skipped') && (needs.hibernate5Functional.result ==
'success' || needs.hibernate5Functional.result == 'skipped') &&
(needs.mongodbFunctional.result == 'success' || needs.mongodbFunctional.result
== 'skipped') }}
Review Comment:
- The always is needed. By default any failure will stop unless the
condition starts with always.
- I'm not sure, let's try!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
