jdaugherty commented on code in PR #14836:
URL: https://github.com/apache/grails-core/pull/14836#discussion_r2174075513
##########
grails-gradle/plugins/src/main/groovy/org/grails/gradle/plugin/publishing/GrailsPublishExtension.groovy:
##########
@@ -93,12 +113,66 @@ class GrailsPublishExtension {
/**
* If another process will add the components set this to false so only
the publication is created
*/
- Boolean addComponents = true
+ final Property<Boolean> addComponents
/**
* The name of the publication
*/
- String publicationName = 'maven'
+ final Property<String> publicationName
+
+ /**
+ * If set, a local repository will be setup for the given path with the
name 'TestCaseMavenRepo'. This can be useful
+ * when testing plugins locally with builds that can't make use of
includedBuild
+ */
+ final Property<Directory> testRepositoryPath
+
+ @Inject
+ GrailsPublishExtension(ObjectFactory objects, Project project) {
+ githubSlug = objects.property(String).convention(
+ project.provider {
+ project.findProperty('githubSlug') as String
+ }
+ )
+ websiteUrl = objects.property(String).convention(project.provider {
+ String githubSlug = githubSlug.getOrNull()
+ githubSlug ? "https://github.com/$githubSlug"; as String : null
+ })
+ scmUrl = objects.property(String).convention(project.provider {
+ String githubSlug = githubSlug.getOrNull()
+ githubSlug ? "https://github.com/$githubSlug"; as String : null
+ })
+ scmUrlConnection =
objects.property(String).convention(project.provider {
+ String githubSlug = githubSlug.getOrNull()
+ githubSlug ? "scm:[email protected]:${githubSlug}.git" as String :
null
+ })
+ vcsUrl = objects.property(String).convention(project.provider {
+ String githubSlug = githubSlug.getOrNull()
+ githubSlug ? "[email protected]:${githubSlug}.git" as String : null
+ })
+ developers = objects.mapProperty(String, String).convention([:])
+ title = objects.property(String).convention(project.provider {
project.name })
+ desc = objects.property(String).convention(project.provider {
+ title.getOrNull()
+ })
+ issueTrackerName =
objects.property(String).convention(project.provider {
+ String githubSlug = githubSlug.getOrNull()
+ githubSlug ? "GitHub Issues" as String : "Issues"
Review Comment:
It was from an earlier iteration. I cleaned this up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
