matrei commented on code in PR #15067:
URL: https://github.com/apache/grails-core/pull/15067#discussion_r2368364273
##########
grails-geb/src/testFixtures/groovy/grails/plugin/geb/WebDriverContainerHolder.groovy:
##########
@@ -243,6 +244,9 @@ class WebDriverContainerHolder {
browser.driver.manage().timeouts().pageLoadTimeout(Duration.ofSeconds(settings.pageLoadTimeout))
if (settings.scriptTimeout != DEFAULT_TIMEOUT_SCRIPT)
browser.driver.manage().timeouts().scriptTimeout(Duration.ofSeconds(settings.scriptTimeout))
+ if (settings.atCheckWaiting != DEFAULT_AT_CHECK_WAITING) {
Review Comment:
My thinking is, that it should not be necessary to have a `GebConfig` to run
`ContainerGebSpec`s (convention over configuration).
For the `grails-core` functional tests for example, we have no `GebConfigs`
(except one).
And if we wanted to set `atCheckWaiting=true` we would have to add a
`GebConfig` to each functional test project.
Now we can just set a system property in CI.
> only will be weird when some things are settable and some not through this
dep
I agree, but this is already the case with stock Geb:
https://groovy.apache.org/geb/manual/current/#system-properties
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
