matrei commented on code in PR #15067:
URL: https://github.com/apache/grails-core/pull/15067#discussion_r2372504718
##########
.github/workflows/gradle.yml:
##########
@@ -173,6 +173,9 @@ jobs:
with:
develocity-access-key: ${{ secrets.GRAILS_DEVELOCITY_ACCESS_KEY }}
- name: "🏃 Run Functional Tests"
+ env:
+ # Make Geb tests more resilient in slow CI environments
+ JAVA_TOOL_OPTIONS: -Dgrails.geb.atCheckWaiting.enabled=true
Review Comment:
> Why make CI work differently then locally?
It should only be a concern in low resource environments, to not get false
positives because the runner can't serve the page fast enough. We see these
random failures in CI.
> Does our JDK read this by default?4
Gradle will automatically pass through the `JAVA_TOOL_OPTIONS` to the JVM,
without needing `systemProperty 'grails.geb.atCheckWaiting.enabled',
System.getProperty('grails.geb.atCheckWaiting.enabled')` in the build file.
> I would have assumed we would have defined this property as part of the
test functional test configuration instead.
We could do that, I think this way is more flexible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
