jdaugherty commented on code in PR #15:
URL:
https://github.com/apache/grails-gradle-publish/pull/15#discussion_r2430108492
##########
.github/workflows/release.yaml:
##########
@@ -337,21 +300,28 @@ jobs:
tag_name: ${{ github.event.release.tag_name }}
files: dev-repo/DIST_SVN_REVISION.txt
- name: "📥 Checkout repository"
- uses: actions/checkout@v4
+ uses: actions/checkout@v5
with:
token: ${{ secrets.GITHUB_TOKEN }} # This should not be needed as
${{ github.token }} is the default, but there have been issues with it.
- ref: v${{ needs.publish.outputs.release_version }}
path: 'grails-publish'
- name: "📧 Print Grails Vote Email"
env:
VERSION: ${{ needs.publish.outputs.release_version }}
- VERSION_COMMIT_ID: ${{ needs.publish.outputs.commit_hash }}
+ VERSION_COMMIT_ID: ${{ github.sha }}
Review Comment:
We modify the the tag as part of the pre-release workflow (to adjust the
version). I don't think this will be correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
