matrei commented on code in PR #15:
URL:
https://github.com/apache/grails-gradle-publish/pull/15#discussion_r2434766277
##########
.github/workflows/release.yaml:
##########
@@ -402,37 +383,34 @@ jobs:
contents: write # required gh-pages update
steps:
- name: "📥 Checkout repository"
- uses: actions/checkout@v4
+ uses: actions/checkout@v5
with:
token: ${{ secrets.GITHUB_TOKEN }} # This should not be needed as
${{ github.token }} is the default, but there have been issues with it.
- fetch-depth: 0 # need the full history to find all tags
- ref: v${{ needs.publish.outputs.release_version }}
+ fetch-depth: 0 # need the full history to find all tags - 🤔 why?
Review Comment:
@jdaugherty Do we need `fetch-depth: 0` here? Is it because it's a
copy/paste from `grails-core` where we use it to create the release drop-down
in the documentation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
