matrei commented on code in PR #15206:
URL: https://github.com/apache/grails-core/pull/15206#discussion_r2493622948


##########
etc/bin/verify.sh:
##########
@@ -114,11 +114,12 @@ set -e
 echo "✅ Reproducible Build Verified"
 
 echo "Be sure to do the following:"
-echo "☑️   Set the override repo: 'export 
GRAILS_REPO_URL=https://repository.apache.org/content/groups/staging' "
-echo "☑️   Run the wrapper ShellApp:  cd 
${DOWNLOAD_LOCATION}/apache-grails-wrapper-${VERSION}-bin/ShellApp && ./gradlew 
bootRun --init-script ~/grails-verify/custom-repos.gradle"
-echo "☑️   Run the wrapper ForgeApp:  cd 
${DOWNLOAD_LOCATION}/apache-grails-wrapper-${VERSION}-bin/ForgeApp && ./gradlew 
bootRun --init-script ~/grails-verify/custom-repos.gradle"
-echo "☑️   Run the cli ShellApp: cd 
${DOWNLOAD_LOCATION}/apache-grails-${VERSION}-bin/bin/ShellApp && ./gradlew 
bootRun --init-script ~/grails-verify/custom-repos.gradle"
-echo "☑️   Run the cli ForgeApp: cd 
${DOWNLOAD_LOCATION}/apache-grails-${VERSION}-bin/bin/ForgeApp && ./gradlew 
bootRun --init-script ~/grails-verify/custom-repos.gradle"
+echo "☑️   Set the override repo: 'export 
GRAILS_REPO_URL=https://repository.apache.org/content/groups/staging'"
+echo "☑️   Run the wrapper ShellApp: cd 
${DOWNLOAD_LOCATION}/apache-grails-wrapper-${VERSION}-bin/ShellApp && ./gradlew 
bootRun --init-script ${DOWNLOAD_LOCATION}/use-staging-repo.gradle"
+echo "☑️   Run the wrapper ForgeApp: cd 
${DOWNLOAD_LOCATION}/apache-grails-wrapper-${VERSION}-bin/ForgeApp && ./gradlew 
bootRun --init-script ${DOWNLOAD_LOCATION}/use-staging-repo.gradle"
+echo "☑️   Run the cli ShellApp: cd 
${DOWNLOAD_LOCATION}/apache-grails-${VERSION}-bin/bin/ShellApp && ./gradlew 
bootRun --init-script ${DOWNLOAD_LOCATION}/use-staging-repo.gradle"
+echo "☑️   Run the cli ForgeApp: cd 
${DOWNLOAD_LOCATION}/apache-grails-${VERSION}-bin/bin/ForgeApp && ./gradlew 
bootRun --init-script ${DOWNLOAD_LOCATION}/use-staging-repo.gradle"
+# BELOW STEP NEEDS CLARIFICATION
 echo "☑️   Add the local repos to the application and then run the shell cli 
from one of the applications and ensure all commands show as expected - pay 
attention to the scaffolding ones since they are dynamically loaded"

Review Comment:
   @jdaugherty Could we re-phrase this last instruction? I cannot make sense of 
it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to