jdaugherty commented on code in PR #15206: URL: https://github.com/apache/grails-core/pull/15206#discussion_r2494354897
########## etc/bin/verify.sh: ########## @@ -114,11 +114,12 @@ set -e echo "✅ Reproducible Build Verified" echo "Be sure to do the following:" -echo "☑️ Set the override repo: 'export GRAILS_REPO_URL=https://repository.apache.org/content/groups/staging' " -echo "☑️ Run the wrapper ShellApp: cd ${DOWNLOAD_LOCATION}/apache-grails-wrapper-${VERSION}-bin/ShellApp && ./gradlew bootRun --init-script ~/grails-verify/custom-repos.gradle" -echo "☑️ Run the wrapper ForgeApp: cd ${DOWNLOAD_LOCATION}/apache-grails-wrapper-${VERSION}-bin/ForgeApp && ./gradlew bootRun --init-script ~/grails-verify/custom-repos.gradle" -echo "☑️ Run the cli ShellApp: cd ${DOWNLOAD_LOCATION}/apache-grails-${VERSION}-bin/bin/ShellApp && ./gradlew bootRun --init-script ~/grails-verify/custom-repos.gradle" -echo "☑️ Run the cli ForgeApp: cd ${DOWNLOAD_LOCATION}/apache-grails-${VERSION}-bin/bin/ForgeApp && ./gradlew bootRun --init-script ~/grails-verify/custom-repos.gradle" +echo "☑️ Set the override repo: 'export GRAILS_REPO_URL=https://repository.apache.org/content/groups/staging'" +echo "☑️ Run the wrapper ShellApp: cd ${DOWNLOAD_LOCATION}/apache-grails-wrapper-${VERSION}-bin/ShellApp && ./gradlew bootRun --init-script ${DOWNLOAD_LOCATION}/use-staging-repo.gradle" +echo "☑️ Run the wrapper ForgeApp: cd ${DOWNLOAD_LOCATION}/apache-grails-wrapper-${VERSION}-bin/ForgeApp && ./gradlew bootRun --init-script ${DOWNLOAD_LOCATION}/use-staging-repo.gradle" +echo "☑️ Run the cli ShellApp: cd ${DOWNLOAD_LOCATION}/apache-grails-${VERSION}-bin/bin/ShellApp && ./gradlew bootRun --init-script ${DOWNLOAD_LOCATION}/use-staging-repo.gradle" +echo "☑️ Run the cli ForgeApp: cd ${DOWNLOAD_LOCATION}/apache-grails-${VERSION}-bin/bin/ForgeApp && ./gradlew bootRun --init-script ${DOWNLOAD_LOCATION}/use-staging-repo.gradle" +# BELOW STEP NEEDS CLARIFICATION echo "☑️ Add the local repos to the application and then run the shell cli from one of the applications and ensure all commands show as expected - pay attention to the scaffolding ones since they are dynamically loaded" Review Comment: The profile generated applications do not add the staging repos directly to the gradle files (https://github.com/apache/grails-core/issues/14887). As a work around, the verify.sh script passes a local-repos.gradle file to gradle commands so that dependencies can be found. Except we cannot do that when running the interactive grails shell. Thus: 1. add the repo manually to an app generated so that the interactive shell does not fail to resolve 2. run the interactive shell under the generated application directory that has had the repos added to the build.gradle 3. type help, which should look up commands dynamically on the class path 4. ensure the scaffolding command is listed This is testing the dynamic resolution of commands in the grails shell for commands not built in (scaffolding is an example) Given all of this, can you help me fix this statement now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
