borinquenkid commented on PR #15654:
URL: https://github.com/apache/grails-core/pull/15654#issuecomment-4529721443
@matrei The missing @IgnoreIf({ System.getProperty('hibernate7.gorm.suite')
}) checks on the TCK tests were actually fixed by commit 5ac6e2c8a and
should all be passing now.
Regarding the "unrelated changes" making this PR too large to review (cc
@sbglasius): The size of this PR is almost entirely due to the 1:1 file clone
of the hibernate5 namespaces into hibernate7
(accounting for ~100k of the 100,754 additions).
The styling and analysis changes are actually minuscule and isolated:
1. The formatting commits touched fewer than 20 source files total (e.g.
f18465a52a touched 1 file, 81c434ba32 touched 14).
2. The static analysis (PMD/CodeNarc), coverage (Jacoco), and test
aggregation configurations are strictly isolated to build-logic/ ,
.github/workflows/ , and grails-test-report/ . They don't
pollute the actual hibernate7 module logic.
3. These changes were pulled forward specifically so that Step 2 (the
actual Hibernate 7 core logic PR) wouldn't be cluttered with them. If we revert
them here, they'll just show up in Step 2, adding
noise to the PR where we actually need to carefully review the Hibernate 7
logic diffs.
Since Step 1 is just the baseline clone, pulling these
build/infrastructure changes forward keeps Step 2 clean. Given this, are we
good to merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
