jamesfredley commented on code in PR #15654:
URL: https://github.com/apache/grails-core/pull/15654#discussion_r3314910653
##########
grails-datamapping-tck/src/main/groovy/org/apache/grails/data/testing/tck/tests/ValidationSpec.groovy:
##########
@@ -45,7 +45,7 @@ class ValidationSpec extends GrailsDataTckSpec {
}
// Hibernate did not originally have this test and it fails for it
- @PendingFeatureIf({ System.getProperty('hibernate5.gorm.suite') })
+ @PendingFeatureIf({ System.getProperty('hibernate5.gorm.suite') ||
System.getProperty('hibernate7.gorm.suite')})
Review Comment:
Update: this is actually already fixed in commit f18465a52a `fix codenarc
violations` (the space before `}` was added back). Verified with `./gradlew
:grails-datamapping-tck:codeStyle` -> BUILD SUCCESSFUL with no codenarc
violations on the TCK module. Marking resolved.
##########
gradle/functional-test-config.gradle:
##########
@@ -60,6 +60,7 @@ List<String> debugArguments = [
]
tasks.withType(Test).configureEach { Test task ->
boolean isHibernate5 =
!project.name.startsWith('grails-test-examples-hibernate5')
+ boolean isHibernate7 =
!project.name.startsWith('grails-test-examples-hibernate7')
boolean isMongo = !project.name.startsWith('grails-test-examples-mongodb')
Review Comment:
Update: this is actually already fixed in commit fbe6d047a2 `Fix negative
check`. The current code at lines 62-64 has NO `!` prefix on the boolean
declarations - `isHibernate5` is now TRUE for h5 projects (not inverted), and
the conditions on lines 76/80/84 (`!isXxx && onlyXxxTests` -> skip) and
88/92/96 (`isXxx && skipXxxTests` -> skip) all read logically. No remaining
issue. Marking resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
