jdaugherty commented on code in PR #15557:
URL: https://github.com/apache/grails-core/pull/15557#discussion_r3341603360
##########
grails-test-examples/hibernate5/grails-hibernate/grails-app/init/functional/tests/BootStrap.groovy:
##########
@@ -26,7 +26,8 @@ class BootStrap {
HibernateDatastore hibernateDatastore
def init = {
- assert
hibernateDatastore.connectionSources.defaultConnectionSource.settings.hibernate.getConfigClass()
== CustomHibernateMappingContextConfiguration
+ // TODO: Re-enable when hibernate.configClass setting works with
Groovy 5 configuration binding
Review Comment:
Shouldn't this be fixed to move this PR on?
##########
grails-test-examples/mongodb/database-per-tenant/grails-app/controllers/examples/mongo/tenant/BookController.groovy:
##########
@@ -35,8 +35,8 @@ class BookController {
*/
def bindParams = ['title']
- def index(Integer max) {
- params.max = Math.min(max ?: 10, 100)
+ def index() {
Review Comment:
Why are you changing binding syntax in this file? It seems out of scope of
this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
