jdaugherty commented on code in PR #15557:
URL: https://github.com/apache/grails-core/pull/15557#discussion_r3341609481
##########
grails-test-examples/micronaut/build.gradle:
##########
@@ -27,6 +27,10 @@ plugins {
version = '0.1'
group = 'micronaut'
+// The Micronaut platform ships org.ow2.asm above what the
grails-micronaut-bom pins; allow the
+// intentional platform override so validateDependencyVersions passes
(apache/grails-core#15677).
+ext.allowedBomOverrides = ['org.ow2.asm:asm', 'org.ow2.asm:asm-util']
Review Comment:
We should be pinning the version in the micronaut bon. This defeats the
purpose of the plugin. Remove this.
##########
grails-test-examples/mongodb/hibernate5/grails-app/controllers/functional/tests/AuthorController.groovy:
##########
@@ -35,8 +35,8 @@ class AuthorController {
*/
def bindParams = ['name']
- def index(Integer max) {
- params.max = Math.min(max ?: 10, 100)
+ def index() {
Review Comment:
Why are you changing binding syntax in this file? It seems out of scope of
this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
