The GitHub Actions job "Code Style" on 
grails-core.git/feat/sitemesh3-default-layout has succeeded.
Run started by GitHub user codeconsole (triggered by codeconsole).

Head commit for run:
a553b4724a2ff1f0ea527110cda8767091dbcc4b / Scott Murphy Heiberg 
<[email protected]>
Model the GSP layout choice as a one-of option to fix the forge UI glitch

Address review feedback on the SiteMesh 3 default change:

- Align the SiteMesh 3 feature title with SiteMesh 2 ("GSP SiteMesh 3
  Layouts") and clean up GspLayoutSpec (single quotes, drop the
  short-lived SNAPSHOT-repo assertions).
- Fix the UI glitch where replacing the default layout left both
  sitemesh3 and grails-layout selected. The two decorators are now
  driven by a single GspLayoutImpl option (SITEMESH3 default,
  GRAILS_LAYOUT) instead of a visible feature card, mirroring the
  servlet and reloading one-of groups. Both members are invisible
  DefaultFeatures that apply based on the selected option, so the
  default-features endpoint always resolves exactly one member.

Threads the option through Options, FeatureFilter, ApplicationController
and ContextFactory, exposes it via select-options (GspLayoutImplDTO /
GspLayoutImplSelectOptions) for the UI dropdown, and adds a --gsp-layout
CLI option. Updates BuildBuilder and GspLayoutSpec and adds
SelectOptionsControllerSpec.

Report URL: https://github.com/apache/grails-core/actions/runs/26980408398

With regards,
GitHub Actions via GitBox

Reply via email to