The GitHub Actions job "Code Style" on 
grails-core.git/feat/sitemesh3-default-layout has succeeded.
Run started by GitHub user codeconsole (triggered by codeconsole).

Head commit for run:
920c12c9019d879a11f6f42e2066ea9aec5cf72e / Scott Murphy Heiberg 
<[email protected]>
Fix empty SiteMesh 3 output for undecorated GSP responses

In the filterless SiteMesh 3 pipeline the GSP capture taglib writes the
full <head>/<body> markup to the response buffer and also captures the
head/body into a Sitemesh3CapturedPage. When no decorator is selected
(e.g. a view with no <meta name="layout"> and no matching convention or
default layout), SiteMeshView writes content.getData() back. The captured
page had neither renderedContent nor pageBuffer set, so getData()
reconstructed only from (empty) properties and emitted an empty
<html><head></head><body></body></html>.

Attach the original response buffer as the captured page's rendered
content in the no-merge branch so the original page is written back when
nothing decorates it. Decorated (meta-layout) pages are unaffected: they
take the decorate branch, which reads the head/body child properties.

Verified against grails-test-examples/app1 integration tests under
SITEMESH3_TESTING_ENABLED=true: ConfigTestControllerSpec,
ControllerIncludesSpec, ControllerFromPluginSpec and
ConditionalOnPropertyFromPluginYmlSpec now pass, with no regression to
meta-layout pages (BookFunctionalSpec).

Report URL: https://github.com/apache/grails-core/actions/runs/27053374634

With regards,
GitHub Actions via GitBox

Reply via email to