codeconsole commented on code in PR #15713:
URL: https://github.com/apache/grails-core/pull/15713#discussion_r3360720915
##########
grails-forge/grails-forge-core/src/main/java/org/grails/forge/feature/sitemesh3/Sitemesh3.java:
##########
@@ -38,12 +44,18 @@ public String getName() {
@Override
public String getTitle() {
- return "Sitemesh 3";
+ return "SiteMesh 3";
Review Comment:
Yes — renamed to `GSP SiteMesh 3 Layouts` to match the SiteMesh 2 title.
##########
grails-forge/grails-forge-core/src/test/groovy/org/grails/forge/feature/view/GspLayoutSpec.groovy:
##########
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.grails.forge.feature.view
+
+import org.grails.forge.ApplicationContextSpec
+import org.grails.forge.BuildBuilder
+import org.grails.forge.application.ApplicationType
+import spock.lang.Unroll
+
+class GspLayoutSpec extends ApplicationContextSpec {
+
+ @Unroll
+ void "web #applicationType apps use SiteMesh 3 (grails-sitemesh3) by
default"() {
+ when:
+ final String build = new BuildBuilder(beanContext)
+ .features(["gsp"])
Review Comment:
Done — converted the spec to single-quoted strings throughout.
##########
grails-forge/grails-forge-core/src/test/groovy/org/grails/forge/feature/view/GspLayoutSpec.groovy:
##########
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.grails.forge.feature.view
+
+import org.grails.forge.ApplicationContextSpec
+import org.grails.forge.BuildBuilder
+import org.grails.forge.application.ApplicationType
+import spock.lang.Unroll
+
+class GspLayoutSpec extends ApplicationContextSpec {
+
+ @Unroll
+ void "web #applicationType apps use SiteMesh 3 (grails-sitemesh3) by
default"() {
+ when:
+ final String build = new BuildBuilder(beanContext)
+ .features(["gsp"])
+ .applicationType(applicationType)
+ .render()
+
+ then:
+ build.contains('implementation "org.apache.grails:grails-sitemesh3"')
+ !build.contains('implementation "org.apache.grails:grails-layout"')
+
+ and: "a SNAPSHOT build exposes the SiteMesh 3 snapshot repo so
org.sitemesh:*-SNAPSHOT resolves"
Review Comment:
Agreed — dropped the SNAPSHOT-repo assertions; the spec now only verifies
the resolved layout dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
