codeconsole commented on PR #15713: URL: https://github.com/apache/grails-core/pull/15713#issuecomment-4628724477
@matrei good catch on the glitch. Root cause: `sitemesh3` (an invisible default) and `grails-layout` (a selectable feature) were an unbound one-of pair, so `/features/default` kept returning `sitemesh3` even after `grails-layout` was selected — hence both showing. Fixed by modeling the choice as a single `GspLayoutImpl` option (`SITEMESH3` default / `GRAILS_LAYOUT`), the same pattern as the servlet and reloading groups: both decorators are now invisible, option-driven defaults, so exactly one ever resolves. The option is threaded through `Options`/`FeatureFilter`/`ContextFactory`, exposed via `/select-options` (`gspLayout`), and added as a `--gsp-layout` CLI flag. This needs a companion SiteMesh-version dropdown in `grails-forge-ui` to drive the new `gspLayout` option (the old `grails-layout` feature card goes away). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
