jamesfredley commented on PR #15730: URL: https://github.com/apache/grails-core/pull/15730#issuecomment-4724030521
@codeconsole Good call - the spec no longer hard-codes the Spring Boot BOM version (or any other version). These specs drive a mocked `GrapeEngine` that matches imported BOMs by module name (and sometimes type), never by version, so every version literal in the fixtures (`4.1.0`, `5.8.0`, `4.0.32`, etc.) was just a synthetic placeholder that happened to look like a real release - not a value resolved from the real BOM. They were never asserting against actual managed versions, which is exactly why they'd be a maintenance burden to keep "current." I've reworked `GrailsDependencyVersionsSpec` so each feature declares arbitrary placeholder version variables, injects them into the synthetic POMs via GStrings, and asserts against those same variables. The specs now verify the parse/import-resolution mechanism and precedence (e.g. a Grails-pinned Groovy still wins over the Spring Boot-managed one) rather than any specific release, so they stay green no matter how the real managed versions move (4.1.x and beyond). Pushed in 635df22. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
