jdaugherty commented on code in PR #15730:
URL: https://github.com/apache/grails-core/pull/15730#discussion_r3433057715
##########
grails-shell-cli/src/main/groovy/org/grails/cli/boot/GrailsDependencyVersions.groovy:
##########
@@ -115,7 +151,11 @@ class GrailsDependencyVersions implements
DependencyManagement {
addDependencyManagement(importedPom)
}
} catch (Exception e) {
- // If the imported BOM cannot be resolved, skip it
Review Comment:
Does this actually occur in the build? I assume this exception should fail
the build
##########
grails-shell-cli/src/main/groovy/org/grails/cli/boot/GrailsDependencyVersions.groovy:
##########
@@ -85,27 +86,62 @@ class GrailsDependencyVersions implements
DependencyManagement {
@CompileDynamic
void addDependencyManagement(GPathResult pom) {
- versionProperties = pom.properties.'*'.collectEntries { [(it.name()):
it.text()] }
Review Comment:
Isn't the core issue that we are trying to manual extract the pom with xml
parsing? The maven model solves all of this, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
