borinquenkid commented on code in PR #15568:
URL: https://github.com/apache/grails-core/pull/15568#discussion_r3439421142
##########
grails-datamapping-tck/src/main/groovy/org/apache/grails/data/testing/tck/tests/NegationSpec.groovy:
##########
@@ -18,15 +18,20 @@
*/
package org.apache.grails.data.testing.tck.tests
-import org.apache.grails.data.testing.tck.base.GrailsDataTckSpec
import org.apache.grails.data.testing.tck.domains.Book
+import org.apache.grails.data.testing.tck.base.GrailsDataTckSpec
/**
* @author graemerocher
*/
class NegationSpec extends GrailsDataTckSpec {
- void 'Test negation in dynamic finder'() {
+ void setupSpec() {
+ manager.addAllDomainClasses([Book])
+ }
+
+ @spock.lang.Requires({ System.getProperty('hibernate5.gorm.suite') ==
'true' || System.getProperty('hibernate7.gorm.suite') == 'true' ||
System.getProperty('mongodb.gorm.suite') == 'true' })
Review Comment:
These `@Requires` annotations were reverted in a prior cleanup commit — the
affected specs run without restrictions in the current branch.
##########
grails-datamapping-tck/src/main/groovy/org/apache/grails/data/testing/tck/tests/ListOrderBySpec.groovy:
##########
@@ -18,16 +18,21 @@
*/
package org.apache.grails.data.testing.tck.tests
-import org.apache.grails.data.testing.tck.base.GrailsDataTckSpec
import org.apache.grails.data.testing.tck.domains.ChildEntity
import org.apache.grails.data.testing.tck.domains.TestEntity
+import org.apache.grails.data.testing.tck.base.GrailsDataTckSpec
/**
* @author graemerocher
*/
class ListOrderBySpec extends GrailsDataTckSpec {
- void 'Test listOrderBy property name method'() {
+ void setupSpec() {
+ manager.addAllDomainClasses([TestEntity, ChildEntity])
+ }
+
+ @spock.lang.Requires({ System.getProperty('hibernate5.gorm.suite') ==
'true' || System.getProperty('hibernate7.gorm.suite') == 'true' ||
System.getProperty('mongodb.gorm.suite') == 'true' })
Review Comment:
These `@Requires` annotations were reverted in a prior cleanup commit — the
affected specs run without restrictions in the current branch.
##########
grails-datamapping-tck/src/main/groovy/org/apache/grails/data/testing/tck/tests/InheritanceSpec.groovy:
##########
@@ -30,9 +30,10 @@ import org.apache.grails.data.testing.tck.domains.Practice
class InheritanceSpec extends GrailsDataTckSpec {
void setupSpec() {
- manager.domainClasses += [Practice]
+ manager.addAllDomainClasses([Practice, City, Country, Location])
}
+ @spock.lang.Requires({ System.getProperty('hibernate5.gorm.suite') ==
'true' || System.getProperty('hibernate7.gorm.suite') == 'true' ||
System.getProperty('mongodb.gorm.suite') == 'true' })
Review Comment:
These `@Requires` annotations were reverted in a prior cleanup commit — the
affected specs run without restrictions in the current branch.
##########
grails-datamapping-tck/src/main/groovy/org/apache/grails/data/testing/tck/tests/GormEnhancerSpec.groovy:
##########
@@ -78,7 +82,8 @@ class GormEnhancerSpec extends GrailsDataTckSpec {
'Bob' == bob.name
}
- void 'Test dynamic finder with disjunction'() {
+ @spock.lang.Requires({ System.getProperty('hibernate5.gorm.suite') ==
'true' || System.getProperty('hibernate7.gorm.suite') == 'true' ||
System.getProperty('mongodb.gorm.suite') == 'true' })
Review Comment:
These `@Requires` annotations were reverted in a prior cleanup commit — the
affected specs run without restrictions in the current branch.
##########
grails-datamapping-tck/src/main/groovy/org/apache/grails/data/testing/tck/tests/GormEnhancerSpec.groovy:
##########
@@ -129,7 +134,8 @@ class GormEnhancerSpec extends GrailsDataTckSpec {
t.id == t.ident()
}
- void 'Test dynamic finder with pagination parameters'() {
+ @spock.lang.Requires({ System.getProperty('hibernate5.gorm.suite') ==
'true' || System.getProperty('hibernate7.gorm.suite') == 'true' ||
System.getProperty('mongodb.gorm.suite') == 'true' })
Review Comment:
These `@Requires` annotations were reverted in a prior cleanup commit — the
affected specs run without restrictions in the current branch.
##########
grails-datamapping-tck/src/main/groovy/org/apache/grails/data/testing/tck/tests/GormEnhancerSpec.groovy:
##########
@@ -146,7 +152,8 @@ class GormEnhancerSpec extends GrailsDataTckSpec {
1 == TestEntity.findAllByNameOrAge('Barney', 40, [max: 1]).size()
}
- void 'Test in list query'() {
+ @spock.lang.Requires({ System.getProperty('hibernate5.gorm.suite') ==
'true' || System.getProperty('hibernate7.gorm.suite') == 'true' ||
System.getProperty('mongodb.gorm.suite') == 'true' })
Review Comment:
These `@Requires` annotations were reverted in a prior cleanup commit — the
affected specs run without restrictions in the current branch.
##########
grails-datamapping-tck/src/main/groovy/org/apache/grails/data/testing/tck/tests/GormEnhancerSpec.groovy:
##########
@@ -164,7 +171,8 @@ class GormEnhancerSpec extends GrailsDataTckSpec {
2 == TestEntity.findAllByNameInListOrName(['Joe', 'Frank'],
'Bob').size()
}
- void 'Test like query'() {
+ @spock.lang.Requires({ System.getProperty('hibernate5.gorm.suite') ==
'true' || System.getProperty('hibernate7.gorm.suite') == 'true' ||
System.getProperty('mongodb.gorm.suite') == 'true' })
Review Comment:
These `@Requires` annotations were reverted in a prior cleanup commit — the
affected specs run without restrictions in the current branch.
##########
grails-datamapping-tck/src/main/groovy/org/apache/grails/data/testing/tck/tests/GormEnhancerSpec.groovy:
##########
@@ -180,7 +188,8 @@ class GormEnhancerSpec extends GrailsDataTckSpec {
results.find { it.name == 'Frank' } != null
}
- void 'Test ilike query'() {
+ @spock.lang.Requires({ System.getProperty('hibernate5.gorm.suite') ==
'true' || System.getProperty('hibernate7.gorm.suite') == 'true' ||
System.getProperty('mongodb.gorm.suite') == 'true' })
Review Comment:
These `@Requires` annotations were reverted in a prior cleanup commit — the
affected specs run without restrictions in the current branch.
##########
grails-datamapping-tck/src/main/groovy/org/apache/grails/data/testing/tck/tests/FindByMethodSpec.groovy:
##########
@@ -18,16 +18,32 @@
*/
package org.apache.grails.data.testing.tck.tests
-import org.apache.grails.data.testing.tck.base.GrailsDataTckSpec
-import org.apache.grails.data.testing.tck.domains.Book
+import spock.lang.Requires
+
+import org.apache.grails.data.testing.tck.domains.Book as TckBook
import org.apache.grails.data.testing.tck.domains.Highway
import org.apache.grails.data.testing.tck.domains.Person
+import org.apache.grails.data.testing.tck.base.GrailsDataTckSpec
+import org.grails.datastore.mapping.core.exceptions.ConfigurationException
+import spock.lang.Unroll
/**
+ * TCK Spec for Dynamic Finders.
+ *
* @author graemerocher
*/
class FindByMethodSpec extends GrailsDataTckSpec {
+ @Override
+ void setupSpec() {
+ manager.addAllDomainClasses([Person, TckBook, Highway])
+ }
+
+ @Requires({
Review Comment:
These `@Requires` annotations were reverted in a prior cleanup commit — the
affected specs run without restrictions in the current branch.
##########
grails-datamapping-tck/src/main/groovy/org/apache/grails/data/testing/tck/tests/FindByMethodSpec.groovy:
##########
@@ -67,6 +83,11 @@ class FindByMethodSpec extends GrailsDataTckSpec {
1 == cnt
}
+ @Requires({
Review Comment:
These `@Requires` annotations were reverted in a prior cleanup commit — the
affected specs run without restrictions in the current branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
