borinquenkid commented on code in PR #15568:
URL: https://github.com/apache/grails-core/pull/15568#discussion_r3439422777
##########
grails-datamapping-tck/src/main/groovy/org/apache/grails/data/testing/tck/tests/PersistenceEventListenerSpec.groovy:
##########
@@ -195,6 +196,7 @@ class PersistenceEventListenerSpec extends
GrailsDataTckSpec {
1 == listener.PostLoadCount
}
+ @spock.lang.Requires({ System.getProperty('hibernate5.gorm.suite') ==
'true' || System.getProperty('hibernate7.gorm.suite') == 'true' ||
System.getProperty('mongodb.gorm.suite') == 'true' })
Review Comment:
These `@Requires` annotations were reverted in a prior cleanup commit — the
affected specs run without restrictions in the current branch.
##########
grails-datamapping-core-test/src/test/groovy/org/grails/datastore/gorm/ListOrderByHungarianNotationSpec.groovy:
##########
@@ -27,9 +27,10 @@ import
org.apache.grails.data.testing.tck.base.GrailsDataTckSpec
*/
class ListOrderByHungarianNotationSpec extends
GrailsDataTckSpec<GrailsDataCoreTckManager> {
void setupSpec() {
- manager.domainClasses.addAll([ClassWithHungarianNotation])
+ manager.addAllDomainClasses([ClassWithHungarianNotation])
}
+ @spock.lang.Requires({ System.getProperty('hibernate5.gorm.suite') ==
'true' || System.getProperty('hibernate7.gorm.suite') == 'true' ||
System.getProperty('mongodb.gorm.suite') == 'true' })
Review Comment:
These `@Requires` annotations were reverted in a prior cleanup commit — the
affected specs run without restrictions in the current branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
