borinquenkid commented on code in PR #15568:
URL: https://github.com/apache/grails-core/pull/15568#discussion_r3440098160
##########
grails-data-hibernate7/grails-plugin/build.gradle:
##########
@@ -72,9 +76,9 @@ dependencies {
testRuntimeOnly 'com.h2database:h2'
testRuntimeOnly 'org.apache.tomcat:tomcat-jdbc'
- testRuntimeOnly 'org.hibernate:hibernate-ehcache', {
+ testRuntimeOnly 'org.hibernate.orm:hibernate-jcache', {
// exclude javax variant of hibernate-core 5.6
Review Comment:
Removed — the `// TODO: Clarify and clean up dependencies` comment was
dropped in the H7 dependency cleanup.
##########
grails-data-hibernate7/grails-plugin/build.gradle:
##########
@@ -72,9 +76,9 @@ dependencies {
testRuntimeOnly 'com.h2database:h2'
testRuntimeOnly 'org.apache.tomcat:tomcat-jdbc'
- testRuntimeOnly 'org.hibernate:hibernate-ehcache', {
+ testRuntimeOnly 'org.hibernate.orm:hibernate-jcache', {
// exclude javax variant of hibernate-core 5.6
- exclude group: 'org.hibernate', module: 'hibernate-core'
+
}
testRuntimeOnly
"org.jboss.spec.javax.transaction:jboss-transaction-api_1.3_spec:$jbossTransactionApiVersion",
{
Review Comment:
Yes — the `exclude group:'javax.transaction', module:'jta'` exclusion is
still needed to prevent the old `javax.transaction:jta` artifact from being
pulled in transitively. Jakarta EE 10 uses `jakarta.transaction` instead.
##########
.agents/skills/hibernate-developer/SKILL.md:
##########
@@ -0,0 +1,119 @@
+---
+name: hibernate-developer
+description: Guide for working in the grails-data-hibernate7 module,
especially Hibernate 7 domain binding, mapping migration, generators, and
integration tests. Use this when changing code or tests under
grails-data-hibernate7.
+license: Apache-2.0
+---
+<!--
+SPDX-License-Identifier: Apache-2.0
+
+Licensed to the Apache Software Foundation (ASF) under one or more contributor
license agreements; and to You under the Apache License, Version 2.0.
+-->
+
+## What I Do
+
+- Provide repository-specific guidance for the `grails-data-hibernate7`
project.
+- Help with Hibernate 7 migration work in domain binding, mapping metadata,
identifiers, generators, collections, and second-pass binding.
+- Guide changes around `GrailsDomainBinder`, `GrailsPropertyBinder`,
`IdentityBinder`, `VersionBinder`, collection binders, and related utilities.
+- Keep changes aligned with the testing constraints and migration status
documented in `grails-data-hibernate7/AGENTS.md`.
Review Comment:
Thanks — the outdated SKILL.md content was revised; stale references to
non-existent AGENTS.md files and migration-specific sections were removed.
##########
.agents/skills/hibernate-developer/SKILL.md:
##########
@@ -0,0 +1,119 @@
+---
+name: hibernate-developer
+description: Guide for working in the grails-data-hibernate7 module,
especially Hibernate 7 domain binding, mapping migration, generators, and
integration tests. Use this when changing code or tests under
grails-data-hibernate7.
+license: Apache-2.0
+---
+<!--
+SPDX-License-Identifier: Apache-2.0
+
+Licensed to the Apache Software Foundation (ASF) under one or more contributor
license agreements; and to You under the Apache License, Version 2.0.
+-->
+
+## What I Do
+
+- Provide repository-specific guidance for the `grails-data-hibernate7`
project.
+- Help with Hibernate 7 migration work in domain binding, mapping metadata,
identifiers, generators, collections, and second-pass binding.
Review Comment:
Thanks — the outdated SKILL.md content was revised; stale references to
non-existent AGENTS.md files and migration-specific sections were removed.
##########
.agents/skills/hibernate-developer/SKILL.md:
##########
@@ -0,0 +1,119 @@
+---
+name: hibernate-developer
+description: Guide for working in the grails-data-hibernate7 module,
especially Hibernate 7 domain binding, mapping migration, generators, and
integration tests. Use this when changing code or tests under
grails-data-hibernate7.
+license: Apache-2.0
+---
+<!--
+SPDX-License-Identifier: Apache-2.0
+
+Licensed to the Apache Software Foundation (ASF) under one or more contributor
license agreements; and to You under the Apache License, Version 2.0.
+-->
+
+## What I Do
+
+- Provide repository-specific guidance for the `grails-data-hibernate7`
project.
+- Help with Hibernate 7 migration work in domain binding, mapping metadata,
identifiers, generators, collections, and second-pass binding.
+- Guide changes around `GrailsDomainBinder`, `GrailsPropertyBinder`,
`IdentityBinder`, `VersionBinder`, collection binders, and related utilities.
+- Keep changes aligned with the testing constraints and migration status
documented in `grails-data-hibernate7/AGENTS.md`.
+
+## When to Use Me
+
+Activate this skill when working on the Hibernate 7 module, especially for:
+
+- Changes under `grails-data-hibernate7/**`.
+- Hibernate 7 mapping and metadata binding work.
+- Identifier, version, collection, association, or generator binding changes.
+- Hibernate 7 regression fixes and migration follow-up tasks.
+- Specs that exercise Hibernate-backed mapping behavior rather than
lightweight unit behavior.
+
+## Module Context
+
+This skill is for the Grails framework's Hibernate 7 integration module, not
for a Grails application. Prefer guidance from this skill over generic Grails
app patterns when working in `grails-data-hibernate7`.
+
+`GrailsDomainBinder` is the main entry point for binding Grails domain classes
to Hibernate metadata. Changes often ripple through:
+
+- `org.grails.orm.hibernate.cfg`
+- `org.grails.orm.hibernate.cfg.domainbinding`
+- `org.grails.orm.hibernate.cfg.domainbinding.collectionType`
+- `org.grails.orm.hibernate.cfg.domainbinding.secondpass`
+- `org.grails.orm.hibernate.cfg.domainbinding.generator`
+
+## Key Classes and Responsibilities
+
+### Main Binding Flow
+
+- `GrailsDomainBinder`: central coordinator for Hibernate 7 mapping
contribution.
+- `GrailsPropertyBinder`: main coordinator for converting persistent
properties into Hibernate `Value` instances.
+- `PropertyFromValueCreator`: shared utility for creating Hibernate `Property`
instances from a bound `Value`.
+
+### Identifier and Version Binding
+
+- `IdentityBinder`: coordinates identifier binding.
+- `SimpleIdBinder`: handles simple identifiers.
+- `CompositeIdBinder`: handles composite identifiers.
+- `VersionBinder`: binds optimistic locking version properties.
+- `NaturalIdentifierBinder`: binds `naturalId` properties.
+
+### Associations and Collections
+
+- `OneToOneBinder`, `ManyToOneBinder`, `ManyToOneValuesBinder`: association
binding.
+- `CollectionBinder`: collection mapping.
+- `CollectionSecondPassBinder`, `ListSecondPassBinder`, `MapSecondPassBinder`:
second-pass association and collection binding.
+- `CollectionHolder` plus the collection type classes: carry collection
metadata through binding.
+
+### Value and Column Binding
+
+- `SimpleValueBinder`: binds simple properties.
+- `SimpleValueColumnBinder`: binds columns to simple values.
+- `ComponentBinder`, `ComponentPropertyBinder`: embedded/component binding.
+- `EnumTypeBinder`: enum mapping.
+
+### Generators
+
+- `BasicValueCreator`: creates identifier values and generators.
+- `GrailsSequenceWrapper`, `GrailsSequenceGeneratorEnum`: generator
integration helpers.
+- `GrailsIdentityGenerator`, `GrailsIncrementGenerator`,
`GrailsNativeGenerator`, `GrailsSequenceStyleGenerator`,
`GrailsTableGenerator`: Grails-specific Hibernate 7 generator implementations.
+
+## Current Module Guidance
+
+Keep these module-specific expectations in mind:
+
+- `GrailsPropertyBinder` has already been simplified to a unified
binder-dispatch structure. Preserve that consolidation instead of reintroducing
scattered property creation or ad hoc branching.
+- Property creation and addition should stay centralized through callers using
`PropertyFromValueCreator` where applicable.
+- Utility classes in `domainbinding.util` should prefer Hibernate-aware GORM
types internally, but public signatures may still need base interfaces when
Spock mocks require them.
+- `GrailsIncrementGenerator` still contains reflection-based Hibernate 7
compatibility workarounds; avoid broad refactors unless the change explicitly
addresses that area.
+
+## Testing Rules
+
+When touching `grails-data-hibernate7`, test through real Hibernate wiring
rather than assuming mocks are enough.
+
+- Use `HibernateGormDatastoreSpec` for Hibernate 7 integration and
domain-binding specifications.
+- Prefer `manager.registerDomainClasses(...)` in `setupSpec()` to register
entities for specs.
+- Define test entities as top-level classes in the same Groovy spec file.
+- Ensure test domain class names are globally unique within the package to
avoid collisions during parallel execution.
Review Comment:
Thanks — the outdated SKILL.md content was revised; stale references to
non-existent AGENTS.md files and migration-specific sections were removed.
##########
.agents/skills/hibernate-developer/SKILL.md:
##########
@@ -0,0 +1,119 @@
+---
+name: hibernate-developer
+description: Guide for working in the grails-data-hibernate7 module,
especially Hibernate 7 domain binding, mapping migration, generators, and
integration tests. Use this when changing code or tests under
grails-data-hibernate7.
+license: Apache-2.0
+---
+<!--
+SPDX-License-Identifier: Apache-2.0
+
+Licensed to the Apache Software Foundation (ASF) under one or more contributor
license agreements; and to You under the Apache License, Version 2.0.
+-->
+
+## What I Do
+
+- Provide repository-specific guidance for the `grails-data-hibernate7`
project.
+- Help with Hibernate 7 migration work in domain binding, mapping metadata,
identifiers, generators, collections, and second-pass binding.
+- Guide changes around `GrailsDomainBinder`, `GrailsPropertyBinder`,
`IdentityBinder`, `VersionBinder`, collection binders, and related utilities.
+- Keep changes aligned with the testing constraints and migration status
documented in `grails-data-hibernate7/AGENTS.md`.
+
+## When to Use Me
+
+Activate this skill when working on the Hibernate 7 module, especially for:
+
+- Changes under `grails-data-hibernate7/**`.
+- Hibernate 7 mapping and metadata binding work.
+- Identifier, version, collection, association, or generator binding changes.
+- Hibernate 7 regression fixes and migration follow-up tasks.
+- Specs that exercise Hibernate-backed mapping behavior rather than
lightweight unit behavior.
+
+## Module Context
+
+This skill is for the Grails framework's Hibernate 7 integration module, not
for a Grails application. Prefer guidance from this skill over generic Grails
app patterns when working in `grails-data-hibernate7`.
+
+`GrailsDomainBinder` is the main entry point for binding Grails domain classes
to Hibernate metadata. Changes often ripple through:
+
+- `org.grails.orm.hibernate.cfg`
+- `org.grails.orm.hibernate.cfg.domainbinding`
+- `org.grails.orm.hibernate.cfg.domainbinding.collectionType`
+- `org.grails.orm.hibernate.cfg.domainbinding.secondpass`
+- `org.grails.orm.hibernate.cfg.domainbinding.generator`
+
+## Key Classes and Responsibilities
+
+### Main Binding Flow
+
+- `GrailsDomainBinder`: central coordinator for Hibernate 7 mapping
contribution.
+- `GrailsPropertyBinder`: main coordinator for converting persistent
properties into Hibernate `Value` instances.
+- `PropertyFromValueCreator`: shared utility for creating Hibernate `Property`
instances from a bound `Value`.
+
+### Identifier and Version Binding
+
+- `IdentityBinder`: coordinates identifier binding.
+- `SimpleIdBinder`: handles simple identifiers.
+- `CompositeIdBinder`: handles composite identifiers.
+- `VersionBinder`: binds optimistic locking version properties.
+- `NaturalIdentifierBinder`: binds `naturalId` properties.
+
+### Associations and Collections
+
+- `OneToOneBinder`, `ManyToOneBinder`, `ManyToOneValuesBinder`: association
binding.
+- `CollectionBinder`: collection mapping.
+- `CollectionSecondPassBinder`, `ListSecondPassBinder`, `MapSecondPassBinder`:
second-pass association and collection binding.
+- `CollectionHolder` plus the collection type classes: carry collection
metadata through binding.
+
+### Value and Column Binding
+
+- `SimpleValueBinder`: binds simple properties.
+- `SimpleValueColumnBinder`: binds columns to simple values.
+- `ComponentBinder`, `ComponentPropertyBinder`: embedded/component binding.
+- `EnumTypeBinder`: enum mapping.
+
+### Generators
+
+- `BasicValueCreator`: creates identifier values and generators.
+- `GrailsSequenceWrapper`, `GrailsSequenceGeneratorEnum`: generator
integration helpers.
+- `GrailsIdentityGenerator`, `GrailsIncrementGenerator`,
`GrailsNativeGenerator`, `GrailsSequenceStyleGenerator`,
`GrailsTableGenerator`: Grails-specific Hibernate 7 generator implementations.
+
+## Current Module Guidance
+
+Keep these module-specific expectations in mind:
+
+- `GrailsPropertyBinder` has already been simplified to a unified
binder-dispatch structure. Preserve that consolidation instead of reintroducing
scattered property creation or ad hoc branching.
+- Property creation and addition should stay centralized through callers using
`PropertyFromValueCreator` where applicable.
+- Utility classes in `domainbinding.util` should prefer Hibernate-aware GORM
types internally, but public signatures may still need base interfaces when
Spock mocks require them.
+- `GrailsIncrementGenerator` still contains reflection-based Hibernate 7
compatibility workarounds; avoid broad refactors unless the change explicitly
addresses that area.
+
+## Testing Rules
+
+When touching `grails-data-hibernate7`, test through real Hibernate wiring
rather than assuming mocks are enough.
+
+- Use `HibernateGormDatastoreSpec` for Hibernate 7 integration and
domain-binding specifications.
+- Prefer `manager.registerDomainClasses(...)` in `setupSpec()` to register
entities for specs.
+- Define test entities as top-level classes in the same Groovy spec file.
+- Ensure test domain class names are globally unique within the package to
avoid collisions during parallel execution.
+- Prefer real entities over heavy mocking for binder logic.
+
+## Change Workflow
+
+1. Identify which binder, creator, generator, fetcher, or second-pass class
owns the behavior.
+2. Trace whether the change affects only `Value` creation, `Property`
creation, or both.
+3. Preserve the existing separation between logical mapping decisions and
Hibernate object construction.
+4. Update or add specs in `grails-data-hibernate7` that exercise the affected
behavior through the public Hibernate-backed path.
+5. Run the relevant Hibernate 7 module tests, and expand test coverage when
binder flow or entity registration behavior changes.
+
+## Pitfalls to Avoid
+
+- Do not treat this module like a simple Grails application layer; it is
framework and mapping infrastructure code.
+- Do not reintroduce duplicated property-creation logic if a shared binder or
creator already owns it.
+- Do not rely on unit-only mocking for Hibernate internals when the behavior
depends on real metadata binding.
+- Do not use nested or inner entity classes in Hibernate 7 specs when
top-level classes are required for AST transforms and reliable registration.
+
+## Known Status and Constraints
+
+- The Hibernate 7 binder migration is largely in migrated state across the
main binders, collection types, second-pass binders, generators, and utilities.
+- Unidirectional many-to-many support in `CollectionSecondPassBinder` is
implemented.
+- `GrailsIncrementGenerator` reflection hacks remain a known temporary
compromise until a later Hibernate upgrade removes the need.
+
Review Comment:
Thanks — the outdated SKILL.md content was revised; stale references to
non-existent AGENTS.md files and migration-specific sections were removed.
##########
.agents/skills/hibernate-developer/SKILL.md:
##########
@@ -0,0 +1,119 @@
+---
+name: hibernate-developer
+description: Guide for working in the grails-data-hibernate7 module,
especially Hibernate 7 domain binding, mapping migration, generators, and
integration tests. Use this when changing code or tests under
grails-data-hibernate7.
+license: Apache-2.0
+---
+<!--
+SPDX-License-Identifier: Apache-2.0
+
+Licensed to the Apache Software Foundation (ASF) under one or more contributor
license agreements; and to You under the Apache License, Version 2.0.
+-->
+
+## What I Do
+
+- Provide repository-specific guidance for the `grails-data-hibernate7`
project.
+- Help with Hibernate 7 migration work in domain binding, mapping metadata,
identifiers, generators, collections, and second-pass binding.
+- Guide changes around `GrailsDomainBinder`, `GrailsPropertyBinder`,
`IdentityBinder`, `VersionBinder`, collection binders, and related utilities.
+- Keep changes aligned with the testing constraints and migration status
documented in `grails-data-hibernate7/AGENTS.md`.
+
+## When to Use Me
+
+Activate this skill when working on the Hibernate 7 module, especially for:
+
+- Changes under `grails-data-hibernate7/**`.
+- Hibernate 7 mapping and metadata binding work.
+- Identifier, version, collection, association, or generator binding changes.
+- Hibernate 7 regression fixes and migration follow-up tasks.
+- Specs that exercise Hibernate-backed mapping behavior rather than
lightweight unit behavior.
+
+## Module Context
+
+This skill is for the Grails framework's Hibernate 7 integration module, not
for a Grails application. Prefer guidance from this skill over generic Grails
app patterns when working in `grails-data-hibernate7`.
+
+`GrailsDomainBinder` is the main entry point for binding Grails domain classes
to Hibernate metadata. Changes often ripple through:
+
+- `org.grails.orm.hibernate.cfg`
+- `org.grails.orm.hibernate.cfg.domainbinding`
+- `org.grails.orm.hibernate.cfg.domainbinding.collectionType`
+- `org.grails.orm.hibernate.cfg.domainbinding.secondpass`
+- `org.grails.orm.hibernate.cfg.domainbinding.generator`
+
+## Key Classes and Responsibilities
+
+### Main Binding Flow
+
+- `GrailsDomainBinder`: central coordinator for Hibernate 7 mapping
contribution.
+- `GrailsPropertyBinder`: main coordinator for converting persistent
properties into Hibernate `Value` instances.
+- `PropertyFromValueCreator`: shared utility for creating Hibernate `Property`
instances from a bound `Value`.
+
+### Identifier and Version Binding
+
+- `IdentityBinder`: coordinates identifier binding.
+- `SimpleIdBinder`: handles simple identifiers.
+- `CompositeIdBinder`: handles composite identifiers.
+- `VersionBinder`: binds optimistic locking version properties.
+- `NaturalIdentifierBinder`: binds `naturalId` properties.
+
+### Associations and Collections
+
+- `OneToOneBinder`, `ManyToOneBinder`, `ManyToOneValuesBinder`: association
binding.
+- `CollectionBinder`: collection mapping.
+- `CollectionSecondPassBinder`, `ListSecondPassBinder`, `MapSecondPassBinder`:
second-pass association and collection binding.
+- `CollectionHolder` plus the collection type classes: carry collection
metadata through binding.
+
+### Value and Column Binding
+
+- `SimpleValueBinder`: binds simple properties.
+- `SimpleValueColumnBinder`: binds columns to simple values.
+- `ComponentBinder`, `ComponentPropertyBinder`: embedded/component binding.
+- `EnumTypeBinder`: enum mapping.
+
+### Generators
+
+- `BasicValueCreator`: creates identifier values and generators.
+- `GrailsSequenceWrapper`, `GrailsSequenceGeneratorEnum`: generator
integration helpers.
+- `GrailsIdentityGenerator`, `GrailsIncrementGenerator`,
`GrailsNativeGenerator`, `GrailsSequenceStyleGenerator`,
`GrailsTableGenerator`: Grails-specific Hibernate 7 generator implementations.
+
+## Current Module Guidance
+
+Keep these module-specific expectations in mind:
+
+- `GrailsPropertyBinder` has already been simplified to a unified
binder-dispatch structure. Preserve that consolidation instead of reintroducing
scattered property creation or ad hoc branching.
+- Property creation and addition should stay centralized through callers using
`PropertyFromValueCreator` where applicable.
+- Utility classes in `domainbinding.util` should prefer Hibernate-aware GORM
types internally, but public signatures may still need base interfaces when
Spock mocks require them.
+- `GrailsIncrementGenerator` still contains reflection-based Hibernate 7
compatibility workarounds; avoid broad refactors unless the change explicitly
addresses that area.
+
+## Testing Rules
+
+When touching `grails-data-hibernate7`, test through real Hibernate wiring
rather than assuming mocks are enough.
+
+- Use `HibernateGormDatastoreSpec` for Hibernate 7 integration and
domain-binding specifications.
+- Prefer `manager.registerDomainClasses(...)` in `setupSpec()` to register
entities for specs.
+- Define test entities as top-level classes in the same Groovy spec file.
+- Ensure test domain class names are globally unique within the package to
avoid collisions during parallel execution.
+- Prefer real entities over heavy mocking for binder logic.
+
+## Change Workflow
+
+1. Identify which binder, creator, generator, fetcher, or second-pass class
owns the behavior.
+2. Trace whether the change affects only `Value` creation, `Property`
creation, or both.
+3. Preserve the existing separation between logical mapping decisions and
Hibernate object construction.
+4. Update or add specs in `grails-data-hibernate7` that exercise the affected
behavior through the public Hibernate-backed path.
+5. Run the relevant Hibernate 7 module tests, and expand test coverage when
binder flow or entity registration behavior changes.
+
+## Pitfalls to Avoid
+
+- Do not treat this module like a simple Grails application layer; it is
framework and mapping infrastructure code.
+- Do not reintroduce duplicated property-creation logic if a shared binder or
creator already owns it.
+- Do not rely on unit-only mocking for Hibernate internals when the behavior
depends on real metadata binding.
+- Do not use nested or inner entity classes in Hibernate 7 specs when
top-level classes are required for AST transforms and reliable registration.
+
+## Known Status and Constraints
+
+- The Hibernate 7 binder migration is largely in migrated state across the
main binders, collection types, second-pass binders, generators, and utilities.
+- Unidirectional many-to-many support in `CollectionSecondPassBinder` is
implemented.
+- `GrailsIncrementGenerator` reflection hacks remain a known temporary
compromise until a later Hibernate upgrade removes the need.
+
+## Source of Truth
+
+This skill is derived from `grails-data-hibernate7/AGENTS.md`. When the module
guidance changes, update this skill so agents can load the same rules directly
from `.agents/skills/hibernate-developer/SKILL.md`.
Review Comment:
Thanks — the outdated SKILL.md content was revised; stale references to
non-existent AGENTS.md files and migration-specific sections were removed.
##########
grails-data-hibernate5/core/src/test/groovy/grails/gorm/tests/AddToManagedEntitySpec.groovy:
##########
@@ -0,0 +1,131 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package grails.gorm.tests
+
+import grails.gorm.annotation.Entity
+import grails.gorm.hibernate.HibernateEntity
+import org.grails.datastore.gorm.GormEntity
+
+/**
+ * Regression tests for H7 "Found two representations of same collection"
error.
+ *
+ * H7 enforces strict collection identity — after an entity is persisted and
+ * managed by the session, calling addTo* and then save(flush:true) must not
+ * replace the Hibernate-tracked PersistentCollection with a plain collection.
+ */
+class AddToManagedEntitySpec extends HibernateGormDatastoreSpec {
+
+ void setupSpec() {
+ manager.registerDomainClasses(CascadeAuthor, CascadeBook)
+ }
+
+ void cleanup() {
+ CascadeBook.withNewTransaction {
+ CascadeBook.executeUpdate('delete from CascadeBook', [:])
+ CascadeAuthor.executeUpdate('delete from CascadeAuthor', [:])
Review Comment:
No — the spec extends `HibernateGormDatastoreSpec`, which wires the H2
config internally. No empty-map constructor argument is needed.
##########
grails-data-hibernate5/core/src/main/groovy/org/grails/orm/hibernate/query/AbstractHibernateQuery.java:
##########
@@ -565,6 +569,18 @@ public ProjectionList projections() {
return hibernateProjectionList;
}
+ @Override
+ public Number countResults() {
Review Comment:
`@since 8.0` is already present on the new `countResults()` override in the
current revision.
##########
grails-data-hibernate5/core/src/test/groovy/grails/gorm/tests/SubclassMultipleListCollectionSpec.groovy:
##########
@@ -41,9 +41,8 @@ class SubclassMultipleListCollectionSpec extends
Specification {
transactionManager = hibernateDatastore.getTransactionManager()
}
- @Ignore // not yet implemented
@Rollback
- @Issue('https://github.com/apache/grails-data-mapping/issues/882')
+ @Issue('https://github.com/grails/grails-data-mapping/issues/882')
Review Comment:
Referenced — `https://github.com/apache/grails-core/issues/14624` was added
to the `@Issue` annotation alongside the original data-mapping issue. The
`@Ignore` was removed; the test now passes.
##########
grails-data-hibernate5/core/src/test/groovy/grails/gorm/tests/TwoBidirectionalOneToManySpec.groovy:
##########
@@ -46,12 +46,30 @@ class TwoBidirectionalOneToManySpec extends Specification {
then:"The entity was saved"
!r.errors.hasErrors()
Room.count == 1
+ PointX.count == 1
+ PointY.count == 1
+
+ }
+
+ @Rollback
+ void "test an entity with 1 one directional one-to-many mappings"() {
+ when:"A new entity is created is created"
Review Comment:
Fixed — the duplicate phrase "is created is created" was corrected to "is
created".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
