borinquenkid commented on code in PR #15568: URL: https://github.com/apache/grails-core/pull/15568#discussion_r3454021295
########## grails-data-hibernate7/grails-plugin/src/main/groovy/grails/test/hibernate/HibernateSpec.groovy: ########## Review Comment: This class is in `main` intentionally — it's a published test support API that downstream apps consume via `testImplementation`. The H5 module follows the same pattern, and the `compileOnly` scope on `spock-core` is the signal that this is a test support library, not a production class. Moving it to `testFixtures` would break consumers. That said, you're right that there's a naming issue — an abstract class called `HibernateSpec` doesn't signal its nature. Added a TODO to rename it to `AHibernateSpec` as a future non-breaking follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
