borinquenkid commented on code in PR #15568:
URL: https://github.com/apache/grails-core/pull/15568#discussion_r3454073564


##########
grails-data-hibernate7/core/src/main/groovy/grails/gorm/hibernate/HibernateEntity.groovy:
##########


Review Comment:
   Reconsidering the previous reply — keeping 
`findAllWithNativeSql`/`findWithNativeSql` as primary. H7 exposes both HQL 
(`findAll`) and native SQL; the name makes the distinction explicit and removes 
ambiguity for users who might not realise they're bypassing Hibernate's query 
parser. The H5 names (`findAllWithSql`/`findWithSql`) are kept as `@Deprecated` 
aliases for migration. Javadoc updated to explain both the HQL distinction and 
GString binding.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to