borinquenkid commented on code in PR #15568: URL: https://github.com/apache/grails-core/pull/15568#discussion_r3470044594
########## grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/cfg/domainbinding/binder/ColumnBinder.java: ########## @@ -0,0 +1,145 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.grails.orm.hibernate.cfg.domainbinding.binder; + +import org.hibernate.mapping.Column; +import org.hibernate.mapping.Table; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import org.grails.orm.hibernate.cfg.ColumnConfig; +import org.grails.orm.hibernate.cfg.Mapping; +import org.grails.orm.hibernate.cfg.PersistentEntityNamingStrategy; +import org.grails.orm.hibernate.cfg.PropertyConfig; +import org.grails.orm.hibernate.cfg.domainbinding.hibernate.HibernateAssociation; +import org.grails.orm.hibernate.cfg.domainbinding.hibernate.HibernatePersistentProperty; +import org.grails.orm.hibernate.cfg.domainbinding.util.BackticksRemover; +import org.grails.orm.hibernate.cfg.domainbinding.util.ColumnNameForPropertyAndPathFetcher; +import org.grails.orm.hibernate.cfg.domainbinding.util.CreateKeyForProps; +import org.grails.orm.hibernate.cfg.domainbinding.util.DefaultColumnNameFetcher; + +@SuppressWarnings({"PMD.NullAssignment", "PMD.DataflowAnomalyAnalysis"}) +public class ColumnBinder { + + private static final Logger LOG = LoggerFactory.getLogger(ColumnBinder.class); + + private final ColumnNameForPropertyAndPathFetcher columnNameForPropertyAndPathFetcher; + private final StringColumnConstraintsBinder stringColumnConstraintsBinder; + private final NumericColumnConstraintsBinder numericColumnConstraintsBinder; + private final CreateKeyForProps createKeyForProps; + private final IndexBinder indexBinder; + + /** Public constructor that accepts all collaborators. */ + public ColumnBinder( + ColumnNameForPropertyAndPathFetcher columnNameForPropertyAndPathFetcher, + StringColumnConstraintsBinder stringColumnConstraintsBinder, + NumericColumnConstraintsBinder numericColumnConstraintsBinder, + CreateKeyForProps createKeyForProps, + IndexBinder indexBinder) { + this.columnNameForPropertyAndPathFetcher = columnNameForPropertyAndPathFetcher; + this.stringColumnConstraintsBinder = stringColumnConstraintsBinder; + this.numericColumnConstraintsBinder = numericColumnConstraintsBinder; + this.createKeyForProps = createKeyForProps; + this.indexBinder = indexBinder; + } + + /** Convenience constructor for backward compatibility. */ + public ColumnBinder(PersistentEntityNamingStrategy namingStrategy) { + this( + new ColumnNameForPropertyAndPathFetcher( + namingStrategy, new DefaultColumnNameFetcher(namingStrategy), new BackticksRemover()), + new StringColumnConstraintsBinder(), + new NumericColumnConstraintsBinder(), + new CreateKeyForProps(new ColumnNameForPropertyAndPathFetcher( + namingStrategy, new DefaultColumnNameFetcher(namingStrategy), new BackticksRemover())), + new IndexBinder()); + } + + /** + * Binds a Column instance to the Hibernate meta model + * + * @param property The Grails domain class property + * @param parentProperty parent property + * @param column The column to bind + * @param path the path + * @param table The table name + */ + public void bindColumn( + HibernatePersistentProperty property, + HibernatePersistentProperty parentProperty, + Column column, + ColumnConfig cc, + String path, + Table table) { + + if (cc != null) { + column.setComment(cc.getComment()); + column.setDefaultValue(cc.getDefaultValue()); + column.setCustomRead(cc.getRead()); + column.setCustomWrite(cc.getWrite()); + } + + Class<?> userType = property.getUserType(); + String columnName = columnNameForPropertyAndPathFetcher.getColumnNameForPropertyAndPath(property, path, cc); + if ((property instanceof HibernateAssociation assoc) && userType == null) { + // Only use conventional naming when the column has not been explicitly mapped. + if (column.getName() == null) { + column.setName(columnName); + } + column.setNullable(assoc.isAssociationColumnNullable()); + } else { + column.setName(columnName); + column.setNullable(property.isNullable() || (parentProperty != null && parentProperty.isNullable())); + // Use the constraints for this property to more accurately define + // the column's length, precision, and scale + Class<?> type = property.getType(); + if (type != null && (String.class.isAssignableFrom(type) || byte[].class.isAssignableFrom(type))) { + PropertyConfig mappedForm = property.getHibernateMappedForm(); + stringColumnConstraintsBinder.bindStringColumnConstraints(column, mappedForm); + } else if (type != null && Number.class.isAssignableFrom(type)) { + PropertyConfig mappedForm = property.getHibernateMappedForm(); + numericColumnConstraintsBinder.bindNumericColumnConstraints(column, cc, mappedForm); + } + } + + createKeyForProps.createKeyForProps(property, path, table, columnName); + indexBinder.bindIndex(columnName, column, cc, table); + + var owner = property.getHibernateOwner(); + if (!owner.isRoot()) { + Mapping mapping = owner.getHibernateMappedForm(); + if (mapping != null && mapping.getTablePerHierarchy()) { + if (LOG.isDebugEnabled()) { + LOG.debug("[GrailsDomainBinder] Sub class property [{}] for column name [{}] set to nullable", property.getName(), column.getName()); Review Comment: Fixed in `ad5114dfab` — stale `[GrailsDomainBinder]` prefix removed from both log messages. ########## grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/cfg/domainbinding/binder/ClassPropertiesBinder.java: ########## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.grails.orm.hibernate.cfg.domainbinding.binder; + +import jakarta.annotation.Nonnull; Review Comment: Done in `ad5114dfab` — switched to `org.jspecify.annotations.NonNull`. ########## grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/cfg/domainbinding/binder/CollectionForPropertyConfigBinder.java: ########## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.grails.orm.hibernate.cfg.domainbinding.binder; + +import java.util.Optional; + +import jakarta.annotation.Nonnull; Review Comment: Done in `ad5114dfab` — switched to `org.jspecify.annotations.NonNull`. ########## grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/cfg/domainbinding/binder/CollectionBinder.java: ########## @@ -0,0 +1,179 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.grails.orm.hibernate.cfg.domainbinding.binder; + +import org.hibernate.boot.spi.InFlightMetadataCollector; +import org.hibernate.boot.spi.MetadataBuildingContext; +import org.hibernate.mapping.Collection; +import org.hibernate.mapping.OneToMany; + +import org.grails.orm.hibernate.cfg.PersistentEntityNamingStrategy; +import org.grails.orm.hibernate.cfg.domainbinding.collectionType.CollectionHolder; +import org.grails.orm.hibernate.cfg.domainbinding.hibernate.HibernateToManyEntityProperty; +import org.grails.orm.hibernate.cfg.domainbinding.hibernate.HibernateToManyProperty; +import org.grails.orm.hibernate.cfg.domainbinding.secondpass.BasicCollectionElementBinder; +import org.grails.orm.hibernate.cfg.domainbinding.secondpass.BidirectionalMapElementBinder; +import org.grails.orm.hibernate.cfg.domainbinding.secondpass.BidirectionalOneToManyLinker; +import org.grails.orm.hibernate.cfg.domainbinding.secondpass.CollectionKeyBinder; +import org.grails.orm.hibernate.cfg.domainbinding.secondpass.CollectionKeyColumnUpdater; +import org.grails.orm.hibernate.cfg.domainbinding.secondpass.CollectionSecondPassBinder; +import org.grails.orm.hibernate.cfg.domainbinding.secondpass.CollectionWithJoinTableBinder; +import org.grails.orm.hibernate.cfg.domainbinding.secondpass.DependentKeyValueBinder; +import org.grails.orm.hibernate.cfg.domainbinding.secondpass.HibernateToManyEntityOrderByBinder; +import org.grails.orm.hibernate.cfg.domainbinding.secondpass.ListSecondPass; +import org.grails.orm.hibernate.cfg.domainbinding.secondpass.ListSecondPassBinder; +import org.grails.orm.hibernate.cfg.domainbinding.secondpass.ManyToOneElementBinder; +import org.grails.orm.hibernate.cfg.domainbinding.secondpass.MapSecondPass; +import org.grails.orm.hibernate.cfg.domainbinding.secondpass.MapSecondPassBinder; +import org.grails.orm.hibernate.cfg.domainbinding.secondpass.PrimaryKeyValueCreator; +import org.grails.orm.hibernate.cfg.domainbinding.secondpass.SetSecondPass; +import org.grails.orm.hibernate.cfg.domainbinding.secondpass.ToManyEntityMultiTenantFilterBinder; +import org.grails.orm.hibernate.cfg.domainbinding.secondpass.UnidirectionalOneToManyBinder; +import org.grails.orm.hibernate.cfg.domainbinding.secondpass.UnidirectionalOneToManyInverseValuesBinder; +import org.grails.orm.hibernate.cfg.domainbinding.util.DefaultColumnNameFetcher; +import org.grails.orm.hibernate.cfg.domainbinding.util.GrailsPropertyResolver; +import org.grails.orm.hibernate.cfg.domainbinding.util.SimpleValueColumnFetcher; +import org.grails.orm.hibernate.cfg.domainbinding.util.TableForManyCalculator; + + +/** Handles the binding of collections to the Hibernate runtime meta model. */ +@SuppressWarnings("PMD.DataflowAnomalyAnalysis") +public class CollectionBinder { + + private final MetadataBuildingContext metadataBuildingContext; + private final CollectionHolder collectionHolder; + private final ListSecondPassBinder listSecondPassBinder; + private final CollectionSecondPassBinder collectionSecondPassBinder; + final MapSecondPassBinder mapSecondPassBinder; + private final InFlightMetadataCollector mappings; + private final TableForManyCalculator tableForManyCalculator; + + public void setComponentBinder(ComponentBinder componentBinder) { + this.collectionSecondPassBinder.setComponentBinder(componentBinder); + } + + /** Creates a new {@link CollectionBinder} instance. */ + public CollectionBinder( + MetadataBuildingContext metadataBuildingContext, + PersistentEntityNamingStrategy namingStrategy, + SimpleValueBinder simpleValueBinder, + EnumTypeBinder enumTypeBinder, + ManyToOneBinder manyToOneBinder, + CompositeIdentifierToManyToOneBinder compositeIdentifierToManyToOneBinder, + SimpleValueColumnFetcher simpleValueColumnFetcher, + CollectionHolder collectionHolder, + InFlightMetadataCollector mappings, + TableForManyCalculator tableForManyCalculator) { + this.metadataBuildingContext = metadataBuildingContext; + this.collectionHolder = collectionHolder; + this.mappings = mappings; + this.tableForManyCalculator = tableForManyCalculator; + GrailsPropertyResolver grailsPropertyResolver = new GrailsPropertyResolver(); + CollectionForPropertyConfigBinder collectionForPropertyConfigBinder = new CollectionForPropertyConfigBinder(); + UnidirectionalOneToManyInverseValuesBinder unidirectionalOneToManyInverseValuesBinder = + new UnidirectionalOneToManyInverseValuesBinder(metadataBuildingContext); + SimpleValueColumnBinder simpleValueColumnBinder = new SimpleValueColumnBinder(); + CollectionWithJoinTableBinder collectionWithJoinTableBinder = new CollectionWithJoinTableBinder( Review Comment: Deferred to the same follow-up PR as the `HibernateCriteriaBuilder` style cleanup. ########## grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/cfg/domainbinding/binder/ClassBinder.java: ########## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.grails.orm.hibernate.cfg.domainbinding.binder; + +import jakarta.annotation.Nonnull; + +import org.hibernate.boot.spi.InFlightMetadataCollector; +import org.hibernate.mapping.PersistentClass; + +import org.grails.orm.hibernate.cfg.Mapping; +import org.grails.orm.hibernate.cfg.domainbinding.hibernate.GrailsHibernatePersistentEntity; + +import static org.grails.orm.hibernate.cfg.GrailsHibernateUtil.unqualify; + +/** The class binder class. */ Review Comment: Done in `ad5114dfab` — Javadoc expanded and `@since 8.0` added. ########## grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/cfg/domainbinding/binder/ComponentBinder.java: ########## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.grails.orm.hibernate.cfg.domainbinding.binder; + +import jakarta.annotation.Nonnull; Review Comment: Done in `ad5114dfab` — switched to `org.jspecify.annotations.NonNull`. ########## grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/cfg/domainbinding/binder/ColumnConfigToColumnBinder.java: ########## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.grails.orm.hibernate.cfg.domainbinding.binder; + +import java.util.Optional; + +import jakarta.annotation.Nonnull; Review Comment: Done in `ad5114dfab` — switched to `org.jspecify.annotations.NonNull`. ########## grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/cfg/domainbinding/binder/ColumnBinder.java: ########## @@ -0,0 +1,145 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.grails.orm.hibernate.cfg.domainbinding.binder; + +import org.hibernate.mapping.Column; +import org.hibernate.mapping.Table; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import org.grails.orm.hibernate.cfg.ColumnConfig; +import org.grails.orm.hibernate.cfg.Mapping; +import org.grails.orm.hibernate.cfg.PersistentEntityNamingStrategy; +import org.grails.orm.hibernate.cfg.PropertyConfig; +import org.grails.orm.hibernate.cfg.domainbinding.hibernate.HibernateAssociation; +import org.grails.orm.hibernate.cfg.domainbinding.hibernate.HibernatePersistentProperty; +import org.grails.orm.hibernate.cfg.domainbinding.util.BackticksRemover; +import org.grails.orm.hibernate.cfg.domainbinding.util.ColumnNameForPropertyAndPathFetcher; +import org.grails.orm.hibernate.cfg.domainbinding.util.CreateKeyForProps; +import org.grails.orm.hibernate.cfg.domainbinding.util.DefaultColumnNameFetcher; + +@SuppressWarnings({"PMD.NullAssignment", "PMD.DataflowAnomalyAnalysis"}) +public class ColumnBinder { + + private static final Logger LOG = LoggerFactory.getLogger(ColumnBinder.class); + + private final ColumnNameForPropertyAndPathFetcher columnNameForPropertyAndPathFetcher; + private final StringColumnConstraintsBinder stringColumnConstraintsBinder; + private final NumericColumnConstraintsBinder numericColumnConstraintsBinder; + private final CreateKeyForProps createKeyForProps; + private final IndexBinder indexBinder; + + /** Public constructor that accepts all collaborators. */ + public ColumnBinder( + ColumnNameForPropertyAndPathFetcher columnNameForPropertyAndPathFetcher, + StringColumnConstraintsBinder stringColumnConstraintsBinder, + NumericColumnConstraintsBinder numericColumnConstraintsBinder, + CreateKeyForProps createKeyForProps, + IndexBinder indexBinder) { + this.columnNameForPropertyAndPathFetcher = columnNameForPropertyAndPathFetcher; + this.stringColumnConstraintsBinder = stringColumnConstraintsBinder; + this.numericColumnConstraintsBinder = numericColumnConstraintsBinder; + this.createKeyForProps = createKeyForProps; + this.indexBinder = indexBinder; + } + + /** Convenience constructor for backward compatibility. */ + public ColumnBinder(PersistentEntityNamingStrategy namingStrategy) { + this( + new ColumnNameForPropertyAndPathFetcher( + namingStrategy, new DefaultColumnNameFetcher(namingStrategy), new BackticksRemover()), + new StringColumnConstraintsBinder(), + new NumericColumnConstraintsBinder(), + new CreateKeyForProps(new ColumnNameForPropertyAndPathFetcher( + namingStrategy, new DefaultColumnNameFetcher(namingStrategy), new BackticksRemover())), + new IndexBinder()); + } + + /** + * Binds a Column instance to the Hibernate meta model + * + * @param property The Grails domain class property + * @param parentProperty parent property + * @param column The column to bind + * @param path the path + * @param table The table name + */ + public void bindColumn( + HibernatePersistentProperty property, + HibernatePersistentProperty parentProperty, + Column column, + ColumnConfig cc, + String path, + Table table) { + + if (cc != null) { + column.setComment(cc.getComment()); + column.setDefaultValue(cc.getDefaultValue()); + column.setCustomRead(cc.getRead()); + column.setCustomWrite(cc.getWrite()); + } + + Class<?> userType = property.getUserType(); + String columnName = columnNameForPropertyAndPathFetcher.getColumnNameForPropertyAndPath(property, path, cc); + if ((property instanceof HibernateAssociation assoc) && userType == null) { + // Only use conventional naming when the column has not been explicitly mapped. + if (column.getName() == null) { + column.setName(columnName); + } + column.setNullable(assoc.isAssociationColumnNullable()); + } else { + column.setName(columnName); + column.setNullable(property.isNullable() || (parentProperty != null && parentProperty.isNullable())); + // Use the constraints for this property to more accurately define + // the column's length, precision, and scale + Class<?> type = property.getType(); + if (type != null && (String.class.isAssignableFrom(type) || byte[].class.isAssignableFrom(type))) { + PropertyConfig mappedForm = property.getHibernateMappedForm(); + stringColumnConstraintsBinder.bindStringColumnConstraints(column, mappedForm); + } else if (type != null && Number.class.isAssignableFrom(type)) { + PropertyConfig mappedForm = property.getHibernateMappedForm(); + numericColumnConstraintsBinder.bindNumericColumnConstraints(column, cc, mappedForm); + } + } + + createKeyForProps.createKeyForProps(property, path, table, columnName); + indexBinder.bindIndex(columnName, column, cc, table); + + var owner = property.getHibernateOwner(); + if (!owner.isRoot()) { + Mapping mapping = owner.getHibernateMappedForm(); + if (mapping != null && mapping.getTablePerHierarchy()) { + if (LOG.isDebugEnabled()) { + LOG.debug("[GrailsDomainBinder] Sub class property [{}] for column name [{}] set to nullable", property.getName(), column.getName()); + } + column.setNullable(true); + } else { + column.setNullable(property.isNullable()); + } + } + + // Apply uniqueness last to ensure it isn't overridden by downstream binders + PropertyConfig mappedFormFinal = property.getHibernateMappedForm(); + column.setUnique(mappedFormFinal.isUnique() && !mappedFormFinal.isUniqueWithinGroup()); + + if (LOG.isDebugEnabled()) { + LOG.debug("[GrailsDomainBinder] bound property [{}] to column name [{}] in table [{}]", property.getName(), column.getName(), table.getName()); Review Comment: Fixed in `ad5114dfab` — same fix, both log messages cleaned up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
