borinquenkid commented on code in PR #15568: URL: https://github.com/apache/grails-core/pull/15568#discussion_r3470047559
########## grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/cfg/domainbinding/binder/ColumnConfigToColumnBinder.java: ########## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.grails.orm.hibernate.cfg.domainbinding.binder; + +import java.util.Optional; + +import jakarta.annotation.Nonnull; + +import org.hibernate.dialect.Dialect; +import org.hibernate.dialect.H2Dialect; +import org.hibernate.dialect.OracleDialect; +import org.hibernate.mapping.Column; + +import org.grails.orm.hibernate.cfg.ColumnConfig; +import org.grails.orm.hibernate.cfg.PropertyConfig; + +public class ColumnConfigToColumnBinder { Review Comment: Done in `ad5114dfab`. ########## grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/cfg/domainbinding/binder/CollectionBinder.java: ########## @@ -0,0 +1,179 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.grails.orm.hibernate.cfg.domainbinding.binder; + +import org.hibernate.boot.spi.InFlightMetadataCollector; +import org.hibernate.boot.spi.MetadataBuildingContext; +import org.hibernate.mapping.Collection; +import org.hibernate.mapping.OneToMany; + +import org.grails.orm.hibernate.cfg.PersistentEntityNamingStrategy; +import org.grails.orm.hibernate.cfg.domainbinding.collectionType.CollectionHolder; +import org.grails.orm.hibernate.cfg.domainbinding.hibernate.HibernateToManyEntityProperty; +import org.grails.orm.hibernate.cfg.domainbinding.hibernate.HibernateToManyProperty; +import org.grails.orm.hibernate.cfg.domainbinding.secondpass.BasicCollectionElementBinder; +import org.grails.orm.hibernate.cfg.domainbinding.secondpass.BidirectionalMapElementBinder; +import org.grails.orm.hibernate.cfg.domainbinding.secondpass.BidirectionalOneToManyLinker; +import org.grails.orm.hibernate.cfg.domainbinding.secondpass.CollectionKeyBinder; +import org.grails.orm.hibernate.cfg.domainbinding.secondpass.CollectionKeyColumnUpdater; +import org.grails.orm.hibernate.cfg.domainbinding.secondpass.CollectionSecondPassBinder; +import org.grails.orm.hibernate.cfg.domainbinding.secondpass.CollectionWithJoinTableBinder; +import org.grails.orm.hibernate.cfg.domainbinding.secondpass.DependentKeyValueBinder; +import org.grails.orm.hibernate.cfg.domainbinding.secondpass.HibernateToManyEntityOrderByBinder; +import org.grails.orm.hibernate.cfg.domainbinding.secondpass.ListSecondPass; +import org.grails.orm.hibernate.cfg.domainbinding.secondpass.ListSecondPassBinder; +import org.grails.orm.hibernate.cfg.domainbinding.secondpass.ManyToOneElementBinder; +import org.grails.orm.hibernate.cfg.domainbinding.secondpass.MapSecondPass; +import org.grails.orm.hibernate.cfg.domainbinding.secondpass.MapSecondPassBinder; +import org.grails.orm.hibernate.cfg.domainbinding.secondpass.PrimaryKeyValueCreator; +import org.grails.orm.hibernate.cfg.domainbinding.secondpass.SetSecondPass; +import org.grails.orm.hibernate.cfg.domainbinding.secondpass.ToManyEntityMultiTenantFilterBinder; +import org.grails.orm.hibernate.cfg.domainbinding.secondpass.UnidirectionalOneToManyBinder; +import org.grails.orm.hibernate.cfg.domainbinding.secondpass.UnidirectionalOneToManyInverseValuesBinder; +import org.grails.orm.hibernate.cfg.domainbinding.util.DefaultColumnNameFetcher; +import org.grails.orm.hibernate.cfg.domainbinding.util.GrailsPropertyResolver; +import org.grails.orm.hibernate.cfg.domainbinding.util.SimpleValueColumnFetcher; +import org.grails.orm.hibernate.cfg.domainbinding.util.TableForManyCalculator; + + +/** Handles the binding of collections to the Hibernate runtime meta model. */ +@SuppressWarnings("PMD.DataflowAnomalyAnalysis") +public class CollectionBinder { + + private final MetadataBuildingContext metadataBuildingContext; + private final CollectionHolder collectionHolder; + private final ListSecondPassBinder listSecondPassBinder; + private final CollectionSecondPassBinder collectionSecondPassBinder; + final MapSecondPassBinder mapSecondPassBinder; + private final InFlightMetadataCollector mappings; + private final TableForManyCalculator tableForManyCalculator; + + public void setComponentBinder(ComponentBinder componentBinder) { + this.collectionSecondPassBinder.setComponentBinder(componentBinder); + } + + /** Creates a new {@link CollectionBinder} instance. */ Review Comment: Removed in `ad5114dfab`. ########## grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/cfg/domainbinding/binder/ColumnBinder.java: ########## @@ -0,0 +1,145 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.grails.orm.hibernate.cfg.domainbinding.binder; + +import org.hibernate.mapping.Column; +import org.hibernate.mapping.Table; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import org.grails.orm.hibernate.cfg.ColumnConfig; +import org.grails.orm.hibernate.cfg.Mapping; +import org.grails.orm.hibernate.cfg.PersistentEntityNamingStrategy; +import org.grails.orm.hibernate.cfg.PropertyConfig; +import org.grails.orm.hibernate.cfg.domainbinding.hibernate.HibernateAssociation; +import org.grails.orm.hibernate.cfg.domainbinding.hibernate.HibernatePersistentProperty; +import org.grails.orm.hibernate.cfg.domainbinding.util.BackticksRemover; +import org.grails.orm.hibernate.cfg.domainbinding.util.ColumnNameForPropertyAndPathFetcher; +import org.grails.orm.hibernate.cfg.domainbinding.util.CreateKeyForProps; +import org.grails.orm.hibernate.cfg.domainbinding.util.DefaultColumnNameFetcher; + +@SuppressWarnings({"PMD.NullAssignment", "PMD.DataflowAnomalyAnalysis"}) +public class ColumnBinder { Review Comment: Done in `ad5114dfab`. ########## grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/cfg/domainbinding/binder/CollectionForPropertyConfigBinder.java: ########## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.grails.orm.hibernate.cfg.domainbinding.binder; + +import java.util.Optional; + +import jakarta.annotation.Nonnull; + +import org.hibernate.mapping.Collection; + +import org.grails.orm.hibernate.cfg.domainbinding.hibernate.HibernateToManyProperty; + +/** The collection for property config binder class. */ Review Comment: Done in `ad5114dfab`. ########## grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/cfg/domainbinding/binder/CollectionBinder.java: ########## @@ -0,0 +1,179 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.grails.orm.hibernate.cfg.domainbinding.binder; + +import org.hibernate.boot.spi.InFlightMetadataCollector; +import org.hibernate.boot.spi.MetadataBuildingContext; +import org.hibernate.mapping.Collection; +import org.hibernate.mapping.OneToMany; + +import org.grails.orm.hibernate.cfg.PersistentEntityNamingStrategy; +import org.grails.orm.hibernate.cfg.domainbinding.collectionType.CollectionHolder; +import org.grails.orm.hibernate.cfg.domainbinding.hibernate.HibernateToManyEntityProperty; +import org.grails.orm.hibernate.cfg.domainbinding.hibernate.HibernateToManyProperty; +import org.grails.orm.hibernate.cfg.domainbinding.secondpass.BasicCollectionElementBinder; +import org.grails.orm.hibernate.cfg.domainbinding.secondpass.BidirectionalMapElementBinder; +import org.grails.orm.hibernate.cfg.domainbinding.secondpass.BidirectionalOneToManyLinker; +import org.grails.orm.hibernate.cfg.domainbinding.secondpass.CollectionKeyBinder; +import org.grails.orm.hibernate.cfg.domainbinding.secondpass.CollectionKeyColumnUpdater; +import org.grails.orm.hibernate.cfg.domainbinding.secondpass.CollectionSecondPassBinder; +import org.grails.orm.hibernate.cfg.domainbinding.secondpass.CollectionWithJoinTableBinder; +import org.grails.orm.hibernate.cfg.domainbinding.secondpass.DependentKeyValueBinder; +import org.grails.orm.hibernate.cfg.domainbinding.secondpass.HibernateToManyEntityOrderByBinder; +import org.grails.orm.hibernate.cfg.domainbinding.secondpass.ListSecondPass; +import org.grails.orm.hibernate.cfg.domainbinding.secondpass.ListSecondPassBinder; +import org.grails.orm.hibernate.cfg.domainbinding.secondpass.ManyToOneElementBinder; +import org.grails.orm.hibernate.cfg.domainbinding.secondpass.MapSecondPass; +import org.grails.orm.hibernate.cfg.domainbinding.secondpass.MapSecondPassBinder; +import org.grails.orm.hibernate.cfg.domainbinding.secondpass.PrimaryKeyValueCreator; +import org.grails.orm.hibernate.cfg.domainbinding.secondpass.SetSecondPass; +import org.grails.orm.hibernate.cfg.domainbinding.secondpass.ToManyEntityMultiTenantFilterBinder; +import org.grails.orm.hibernate.cfg.domainbinding.secondpass.UnidirectionalOneToManyBinder; +import org.grails.orm.hibernate.cfg.domainbinding.secondpass.UnidirectionalOneToManyInverseValuesBinder; +import org.grails.orm.hibernate.cfg.domainbinding.util.DefaultColumnNameFetcher; +import org.grails.orm.hibernate.cfg.domainbinding.util.GrailsPropertyResolver; +import org.grails.orm.hibernate.cfg.domainbinding.util.SimpleValueColumnFetcher; +import org.grails.orm.hibernate.cfg.domainbinding.util.TableForManyCalculator; + + +/** Handles the binding of collections to the Hibernate runtime meta model. */ Review Comment: Done in `ad5114dfab`. ########## grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/cfg/domainbinding/binder/ComponentBinder.java: ########## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.grails.orm.hibernate.cfg.domainbinding.binder; + +import jakarta.annotation.Nonnull; + +import org.hibernate.boot.spi.MetadataBuildingContext; +import org.hibernate.mapping.Collection; +import org.hibernate.mapping.Component; +import org.hibernate.mapping.PersistentClass; + +import org.grails.orm.hibernate.cfg.GrailsHibernateUtil; +import org.grails.orm.hibernate.cfg.MappingCacheHolder; +import org.grails.orm.hibernate.cfg.domainbinding.hibernate.GrailsHibernatePersistentEntity; +import org.grails.orm.hibernate.cfg.domainbinding.hibernate.HibernateEmbeddedCollectionProperty; +import org.grails.orm.hibernate.cfg.domainbinding.hibernate.HibernateEmbeddedProperty; +import org.grails.orm.hibernate.cfg.domainbinding.hibernate.HibernatePersistentProperty; + +// TODO (Hibernate 8 refactor): ComponentBinder holds a GrailsPropertyBinder reference set post-construction +// via setGrailsPropertyBinder() to break a circular dependency (ComponentBinder ↔ GrailsPropertyBinder ↔ +// CollectionBinder ↔ ComponentBinder). This mutual dependency should be resolved by introducing a shared +// binding context or factory object that all binders receive at construction time. +@SuppressWarnings("PMD.DataflowAnomalyAnalysis") +public class ComponentBinder { Review Comment: Done in `ad5114dfab`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
