borinquenkid commented on code in PR #15768:
URL: https://github.com/apache/grails-core/pull/15768#discussion_r3476954366
##########
grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/HibernateGormStaticApi.groovy:
##########
@@ -275,11 +275,11 @@ class HibernateGormStaticApi<D> extends GormStaticApi<D> {
doListInternal(query, namedParams, [], args, false)
}
- D findWithNativeSql(CharSequence sql, Map args = Collections.emptyMap()) {
+ D findWithSql(CharSequence sql, Map args = Collections.emptyMap()) {
doSingleInternal(sql, [:], [], args, true) as D
}
- List<D> findAllWithNativeSql(CharSequence query, Map args =
Collections.emptyMap()) {
+ List<D> findAllWithSql(CharSequence query, Map args =
Collections.emptyMap()) {
doListInternal(query, [:], [], args, true)
}
Review Comment:
Thank you for the review. However, these method names (`findWithNativeSql` /
`findAllWithNativeSql`) were never part of a published/released version — they
only existed in the unreleased `8.0.x` branch. Their presence there was
accidental (an unintentional API exposure), so this PR is reverting them back
to the internal names used in H5. Since no external callers have ever had
access to a released build containing these names, there is no source/binary
compatibility concern here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
