jamesfredley commented on code in PR #15768:
URL: https://github.com/apache/grails-core/pull/15768#discussion_r3482765781
##########
grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/HibernateGormStaticApi.groovy:
##########
@@ -275,11 +275,11 @@ class HibernateGormStaticApi<D> extends GormStaticApi<D> {
doListInternal(query, namedParams, [], args, false)
}
- D findWithNativeSql(CharSequence sql, Map args = Collections.emptyMap()) {
+ D findWithSql(CharSequence sql, Map args = Collections.emptyMap()) {
doSingleInternal(sql, [:], [], args, true) as D
}
- List<D> findAllWithNativeSql(CharSequence query, Map args =
Collections.emptyMap()) {
+ List<D> findAllWithSql(CharSequence query, Map args =
Collections.emptyMap()) {
doListInternal(query, [:], [], args, true)
}
Review Comment:
Fixed in 92b2c98fa8. The H7 docs and upgrade notes now document
`findWithSql` / `findAllWithSql` as the supported SQL helper names and no
longer describe `*NativeSql` methods or deprecate the historical names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
