The GitHub Actions job "CI - Groovy Joint Validation Build" on 
grails-core.git/fix/plugin-dependency-diagnostics has succeeded.
Run started by GitHub user borinquenkid (triggered by borinquenkid).

Head commit for run:
9e732621461bec6e48ecd93efb17cd3186f6b6eb / Walter Duque de Estrada 
<[email protected]>
Address review feedback on plugin dependency diagnostics

- Revert the unresolved-dependency log from WARN back to ERROR, per
  jdaugherty and davydotcom (davydotcom revised an initial approval to
  CHANGES_REQUESTED specifically for this): unresolved dependencies are
  a real load failure - the plugin already lands in failedPlugins - and
  the prior code logged it at ERROR. WARN risked being filtered out of
  environments that only surface errors.
- Fix logUnresolvedDependencies() misclassifying a dependency as
  "missing" whenever it isn't yet registered, even when the dependency
  plugin actually exists but itself failed to load or is still waiting
  in the delayed-load queue (flagged independently by Copilot's inline
  review and bito-code-review's bot comment; verified by tracing
  loadDelayedPlugins()'s processing order). Now distinguishes three
  cases: registered with an incompatible version (unchanged), found in
  failedPlugins ("failed to load"), found in delayedLoadPlugins ("is
  still pending load"), and only "is missing" when none of the above.

Co-Authored-By: Claude Sonnet 5 <[email protected]>

Report URL: https://github.com/apache/grails-core/actions/runs/30293578371

With regards,
GitHub Actions via GitBox

Reply via email to