The GitHub Actions job "CI" on grails-core.git/chore/remove-jodd-wot has 
succeeded.
Run started by GitHub user borinquenkid (triggered by borinquenkid).

Head commit for run:
3b8b35feafd7d57471deb1d5594969cc1551a553 / Walter Duque de Estrada 
<[email protected]>
Replace string assertions with Jsoup DOM parsing per review discussion

jdaugherty flagged the string-based assertions this PR introduced as
fragile (exact-serialization matching instead of semantic checks), and
Copilot independently raised the same concern per-assertion. jamesfredley
proposed the trade-off directly: stay dependency-free with tightened
(regex) assertions, or trade the removed jodd-wot for a real, modern
parser (Jsoup). jdaugherty chose Jsoup explicitly, anticipating more
HTML-structure-sensitive tests from planned refactoring.

Reimplements the three DefaultFieldTemplateSpec assertions against
org.jsoup instead of raw strings, restoring the exact semantic checks
the original jodd-wot/Jerry version had (root div has the fieldcontain/
error/required class tokens - order and other-attributes insensitive -
label text/for-attribute, label immediately precedes the input, and the
required-indicator span's text) rather than the newly-added brittle
literal-markup comparisons.

jsoup has no existing version management in this repo; added
jsoupVersion to gradle.properties following the same pattern already
used for javassistVersion/jnrPosixVersion, since it's a single-module,
test-only dependency.

Co-Authored-By: Claude Sonnet 5 <[email protected]>

Report URL: https://github.com/apache/grails-core/actions/runs/30298842093

With regards,
GitHub Actions via GitBox

Reply via email to