matrei commented on code in PR #16174:
URL: https://github.com/apache/grails-core/pull/16174#discussion_r3821173034
##########
.github/workflows/gradle.yml:
##########
@@ -567,6 +567,46 @@ jobs:
--stacktrace
-DTESTCONFIG=${{ matrix.test-config }}
-PskipCodeStyle
+ casSecurityConfig:
+ name: "Spring Security CAS Functional Tests"
+ if: ${{ !contains(github.event.head_commit.message, '[skip tests]') }}
+ strategy:
+ fail-fast: false
+ matrix:
+ # The CAS test app authenticates against a real Apereo CAS server
started via Testcontainers.
+ # 'cas' leaves the proxy settings unset and is the default, so it is
also covered by the main
+ # security job; 'casProxy' exercises the proxy-granting-ticket
callback; 'casNoSingleSignout'
+ # asserts the shipped default, where single signout is not enabled.
+ # TESTCONFIG is applied at app startup, so every config must be its
own run.
+ # Carried over from the standalone grails-spring-security CI
convention - add, don't remove.
+ test-config: [ 'cas', 'casProxy', 'casNoSingleSignout' ]
Review Comment:
Will the 'cas' test-config will be run twice? Once in `security` job and
then again here?
##########
grails-spring-security/cas/plugin/src/main/groovy/grails/plugin/springsecurity/cas/SpringSecurityCasGrailsPlugin.groovy:
##########
@@ -35,11 +36,14 @@ import
org.springframework.security.cas.authentication.CasAuthenticationProvider
import org.springframework.security.cas.authentication.NullStatelessTicketCache
import org.springframework.security.cas.web.CasAuthenticationEntryPoint
import org.springframework.security.cas.web.CasAuthenticationFilter
+import
org.springframework.security.web.authentication.session.NullAuthenticatedSessionStrategy
+import grails.plugin.springsecurity.BeanTypeResolver
import grails.plugin.springsecurity.SecurityFilterPosition
import grails.plugin.springsecurity.SpringSecurityUtils
import grails.plugins.Plugin
+@Slf4j
@CompileStatic
class SpringSecurityCasGrailsPlugin extends Plugin {
Review Comment:
While we are here:
- Should we bump `grailsVersion`?
- Jasig -> Apereo?
- organization metadata?
- issueManagement metadata?
- scm metadata?
##########
grails-test-examples/spring-security/cas/README.md:
##########
@@ -16,19 +16,73 @@ limitations under the License.
This is a CAS-enabled test application. To run it successfully, a CAS
server is required. The URL for the CAS server is configured in the
-[application.groovy](test1/grails-app/conf/application.groovy)
-file. Setting up a CAS server is out of the scope of this document, but
-good places to start are [Apereo CAS GitHub](https://github.com/apereo/cas)
-and the [CAS Initializr](https://getcas.apereo.org/ui) service.
+This is a CAS-enabled test application. It no longer needs a hand-run CAS
server: an
Review Comment:
The seems to be some leftover here...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
