sbglasius commented on code in PR #16174:
URL: https://github.com/apache/grails-core/pull/16174#discussion_r3824024972
##########
.github/workflows/gradle.yml:
##########
@@ -567,6 +567,46 @@ jobs:
--stacktrace
-DTESTCONFIG=${{ matrix.test-config }}
-PskipCodeStyle
+ casSecurityConfig:
+ name: "Spring Security CAS Functional Tests"
+ if: ${{ !contains(github.event.head_commit.message, '[skip tests]') }}
+ strategy:
+ fail-fast: false
+ matrix:
+ # The CAS test app authenticates against a real Apereo CAS server
started via Testcontainers.
+ # 'cas' leaves the proxy settings unset and is the default, so it is
also covered by the main
+ # security job; 'casProxy' exercises the proxy-granting-ticket
callback; 'casNoSingleSignout'
+ # asserts the shipped default, where single signout is not enabled.
+ # TESTCONFIG is applied at app startup, so every config must be its
own run.
+ # Carried over from the standalone grails-spring-security CI
convention - add, don't remove.
+ test-config: [ 'cas', 'casProxy', 'casNoSingleSignout' ]
Review Comment:
Yes, and actually three times rather than twice. The specs defaulted to the
cas configuration when `TESTCONFIG` was unset, so the security job picked it up
in its Java 21 entry and one of its Java 25 shards, plus the run here.
Fixed in e4a3e8e by requiring a configuration to be selected, which is what
the core functional-test-app specs already do — every one of them is gated on
`TESTCONFIG`, so a run without it exercises none of them. The security job now
skips all CAS specs (and no longer pulls the 882 MB CAS image at all), and each
configuration runs exactly once here. `bootRun` still needs no `TESTCONFIG`.
One trade-off worth flagging:
`:grails-test-examples-spring-security-cas-test1:check` without `-DTESTCONFIG`
now reports no CAS tests. That matches the core app's behaviour and is called
out in the `README`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
