Copilot commented on code in PR #16236:
URL: https://github.com/apache/grails-core/pull/16236#discussion_r3877488592
##########
grails-forge/grails-forge-web-netty/build.gradle:
##########
@@ -24,6 +24,8 @@ plugins {
id 'io.micronaut.application' version "$micronautApplicationPluginVersion"
}
+import com.github.jengelman.gradle.plugins.shadow.tasks.ShadowJar
Review Comment:
`import` statements must appear before any executable statements in a
Groovy/Gradle script; placing the `ShadowJar` import after the `plugins {}`
block will cause the build script to fail to compile ("unexpected token:
import"). Move the import above the `plugins` block (or remove the import and
avoid typed `tasks.named(...)`).
##########
grails-forge/grails-forge-api/src/test/groovy/org/grails/forge/api/ApplicationControllerSpec.groovy:
##########
@@ -19,6 +19,7 @@
package org.grails.forge.api
+import io.micronaut.context.annotation.Property
Review Comment:
`io.micronaut.context.annotation.Property` is only valid on
fields/parameters and cannot be applied at the class level, so this test will
not compile. Use the Micronaut test annotation instead (e.g.,
`io.micronaut.test.annotation.Property`) for class-level test property
overrides.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
