jamesfredley commented on code in PR #16236:
URL: https://github.com/apache/grails-core/pull/16236#discussion_r3877615468
##########
grails-forge/grails-forge-web-netty/build.gradle:
##########
@@ -24,6 +24,8 @@ plugins {
id 'io.micronaut.application' version "$micronautApplicationPluginVersion"
}
+import com.github.jengelman.gradle.plugins.shadow.tasks.ShadowJar
Review Comment:
Not valid for this Gradle Groovy DSL. `plugins {}` must be first; an
`import` after that block is legal. `:grails-forge-web-netty` already compiled
and packaged in CI (Build Grails Forge 21 passed) and locally via
`awsElasticBeanstalk`. Moving the import above `plugins {}` would be the
invalid change.
##########
grails-forge/grails-forge-api/src/test/groovy/org/grails/forge/api/ApplicationControllerSpec.groovy:
##########
@@ -19,6 +19,7 @@
package org.grails.forge.api
+import io.micronaut.context.annotation.Property
Review Comment:
Not valid on this Micronaut 3.10.4 line.
`io.micronaut.context.annotation.Property` has no restrictive `@Target`, and
`io.micronaut.test.annotation.Property` does not exist in `micronaut-test-core`
3.9.x. This class-level usage compiled and ran in CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
