zyro23 commented on issue #16029:
URL: https://github.com/apache/grails-core/issues/16029#issuecomment-5503209387

   @borinquenkid @jdaugherty @matrei perhaps it makes sense then to mention 
this in the upgrade notes regarding bean registration.
   
   it was not incidental that it worked previsouly, ref. 
https://github.com/apache/grails-core/pull/545
   
   dropping support for second-pass configuration class processing results in a 
breaking change, e.g. for 
[grails-spring-websocket](https://github.com/zyro23/grails-spring-websocket/tree/v2.5.0.RC1#custom-configuration)
 which used to rely on plugin users being able to override a plugin-shipped 
default configuration class/bean via the `resources.groovy` dsl.
   
   that said, i am fine with this as a design decision.
   
   n.b.: and then i guess `grailsConfigurationClassPostProcessor` could/should 
be removed from `CoreGrailsPlugin` altogether:  
   
https://github.com/apache/grails-core/blame/v8.0.0-M6/grails-core/src/main/groovy/org/grails/plugins/CoreGrailsPlugin.groovy#L161-L181
  
   cc @codeconsole as he seems to have given that some thought a few weeks ago
   
   thanks & regards.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to