matrei commented on issue #16029:
URL: https://github.com/apache/grails-core/issues/16029#issuecomment-5507549905
@zyro23 You are right, it was was clearly not incidental that it worked. It
was just not documented.
The use case for custom configuration in `grails-spring-websocket` is valid
and can also be accomplished with:
```groovy
@Configuration('webSocketConfig')
@EnableWebSocketMessageBroker
class MyWebSocketConfig implements WebSocketMessageBrokerConfigurer {
// ...
}
```
```groovy
@Import(MyWebSocketConfig)
class Application extends GrailsAutoConfiguration {
static void main(String[] args) {
GrailsApp.run(Application, args)
}
}
```
An alternative approach, since the plugin now uses Boot auto-configuration,
it could keep `@EnableWebSocketMessageBroker` and the Grails-specific
infrastructure beans in plugin-owned auto-configuration, while exposing broker
and endpoint customization through ordinary strategy/customizer beans or
configuration properties. Applications would then no longer need to replace an
entire `@Configuration` class, eliminating the need for second-pass
configuration processing for this use case.
We should either way:
- document the breaking change
or
- add back support for a second-pass configuration post-processing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
