codeconsole commented on PR #16208: URL: https://github.com/apache/grails-core/pull/16208#issuecomment-5684707676
Addressed the six findings in 1726f84d3a5ec8a32b5940936f875d7674604fde: 1. Closing the parent now interrupts every child index-build executor before closing clients. Regression coverage includes connections configured at startup and added at runtime, with no erroneous shutdown failure logs. 2. Added tenancy mode and tenant-isolation coverage for supplied clients, and updated the release notes and PR description. The tests also exposed a missing `grails.gorm` fallback; supplied-client settings now inherit it, with `grails.mongodb` overrides taking precedence. 3. Idle index-build workers exit after one second. A later explicit build can start a new worker. 4. Startup builds call the existing protected `initializeIndices(PersistentEntity)` hook again, preserving subclass behavior and build summaries. Both synchronous/asynchronous startup and later registration are covered. 5. Successful creation, recreation, and TTL updates refresh the index snapshot. Tests cover duplicate declarations and repeated text-index recreation using the latest name. 6. Clarified concurrency across connections and the domain-class count. Added a test for the documented camel-case configuration names. Validation completed: - Focused regression run: 44 passed. - Full MongoDB core suite: 669 passed, 45 skipped, zero failures. - MongoDB core Checkstyle and CodeNarc passed; all four aggregate violation reports were clean. - MongoDB documentation build passed. The full repository run was interrupted by a Gradle daemon shutdown. Its retry was stopped on request; full-repository validation remains incomplete. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
