codeconsole commented on PR #16208: URL: https://github.com/apache/grails-core/pull/16208#issuecomment-5764945945
Addressed round 3 and the review of @jdaugherty's 14 comments; there is a reply on each thread. **Round 3, finding 1 (`tenantResolverClass`).** Pinned in 4c074122eb: with the resolver named by class the datastore resolves with that class, and without it `NoTenantResolver` stays in place. **The 14 comments,** following your triage: - Fixed, each with a test: the shared compound-index declaration (4a4733ac09), the supplied mapping context's database (8a7e1ff4c4), the `ConcurrentHashMap` (f4bb9466e6), the log capture (fd13f1a3d6), and in 848282548a the re-listing on conflict, `buildIndex()` after `close()`, `stop()`/`start()`, and the summary on a build that stops partway. - A drop-and-recreate is counted as recreated rather than making `contains()` strict; the Javadoc note on the hook; the `isInfoEnabled()` gate on the listing; and `CustomizableThreadFactory`, with the documented thread name now `gorm-mongo-index-build-<connection>-<n>`. - The kebab-case NOTE stays, with a feature through a Boot-attached environment added (423ac93345). The ThreadLocal stays, with the reason on that thread. **Run locally:** `:grails-data-mongodb-core:cleanTest :grails-data-mongodb-core:check --no-build-cache --continue` gives 785 tests, 0 failures, 0 errors, 45 skipped across 224 result files, with `checkstyleMain` and `codenarcMain` clean. `LocalMongoUnitSpec` passes both features. `:grails-data-mongodb-docs:asciidoctor` succeeds, and root `aggregateViolations` and `rat` are clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
