codeconsole commented on PR #16208: URL: https://github.com/apache/grails-core/pull/16208#issuecomment-5768881604
Addressed the seven open items; there is a reply on each thread. - **Fixed:** classification is now per collection, with the summary keeping the breakdown and reporting the rest as "applied without a listing"; a failure during shutdown counts as abandoned only if the shutdown explains it; the synchronous half of the registration guard; `start()` no longer waiting on, or re-running, a connection added while stopped, with the wait cut to one second; the connection name in every build log line, and the background announcement moved after the submission; and `codecRegistry` made `volatile`. All are in c6a64e8d1e, each with a test. - **Upgrade note:** it now says the connection details are the exception, and that a named connection on the supplied-client path wants its own `url` (0ffc9215e7). - **CRaC:** the three pre-existing gaps are filed as #16366, credited to @jdaugherty. **Run locally,** on the head with `-PmaxTestParallel=4` and the `docker events` watcher: JDK 21, `:grails-data-mongodb-core:cleanTest :grails-data-mongodb-core:check --no-build-cache --continue`, gives 804 tests, 0 failures, 0 errors, 45 skipped, with `checkstyleMain` and `codenarcMain` clean and no mongod exit. `:grails-data-mongodb-docs:asciidoctor`, root `aggregateViolations` and `rat` are clean. I did not repeat the JDK 25 runs this round; CI covers them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
