codeconsole commented on PR #16208: URL: https://github.com/apache/grails-core/pull/16208#issuecomment-5769573963
@jdaugherty thanks, both taken in 91a7eb489b: - **Doc**: "What the Index Build Reports" now explains `applied without a listing` and when the `index declaration(s) applied` form appears (replied in its thread). - **Announcement order**: the background build now logs its announcement as the first thing the submitted task does, so it comes from the build thread and always precedes the build's own lines. `BuildIndexesAsyncSpec` pins it: announcement and summary from the same thread, announcement first. Four lifecycle tests had relied on the announcement being logged on the calling thread as their synchronous sign that `start()` did or did not re-run a build. `start()` now logs `Resuming the index build for connection [...] that was pending while the datastore was stopped.` on its own thread when it does, and those tests assert on that instead. It also tells an operator why a build starts again after a restore. The `IllegalStateException` breadth and the self-cause-only cycle guard are left as they are. One thing to look at before merging: your approval was on c6a64e8d1e, and 7d927e10be came after it. `buildIndex()` now runs when the application calls it even with `buildIndexes: false`; the setting turns off only the builds GORM starts by itself. It is documented under "Building Indexes on Demand" and covered by `BuildIndexesOnDemandSpec`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
