codecov[bot] commented on PR #16414: URL: https://github.com/apache/grails-core/pull/16414#issuecomment-5848041626
## [Codecov](https://app.codecov.io/gh/apache/grails-core/pull/16414?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `78.29457%` with `56 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 57.7307%. Comparing base ([`abcb4b8`](https://app.codecov.io/gh/apache/grails-core/commit/abcb4b8e2d17811eb5e15afe8b6cd31c89d5e5aa?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`50d97be`](https://app.codecov.io/gh/apache/grails-core/commit/50d97beae41cc77e14511acde6cf827c485e0914?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/grails-core/pull/16414?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ails/web/converters/jackson/JacksonJSONWriter.java](https://app.codecov.io/gh/apache/grails-core/pull/16414?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fconverters%2Fjackson%2FJacksonJSONWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2NvbnZlcnRlcnMvamFja3Nvbi9KYWNrc29uSlNPTldyaXRlci5qYXZh) | 74.5098% | [16 Missing and 10 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16414?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rails/web/json/PathCapturingJSONWriterWrapper.java](https://app.codecov.io/gh/apache/grails-core/pull/16414?src=pr&el=tree&filepath=grails-web-common%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fjson%2FPathCapturingJSONWriterWrapper.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXdlYi1jb21tb24vc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2pzb24vUGF0aENhcHR1cmluZ0pTT05Xcml0ZXJXcmFwcGVyLmphdmE=) | 36.3636% | [8 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16414?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ails/web/converters/jackson/JsonMapperSupport.java](https://app.codecov.io/gh/apache/grails-core/pull/16414?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fconverters%2Fjackson%2FJsonMapperSupport.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2NvbnZlcnRlcnMvamFja3Nvbi9Kc29uTWFwcGVyU3VwcG9ydC5qYXZh) | 70.2703% | [4 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16414?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...b/converters/marshaller/json/RecordMarshaller.java](https://app.codecov.io/gh/apache/grails-core/pull/16414?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fconverters%2Fmarshaller%2Fjson%2FRecordMarshaller.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2NvbnZlcnRlcnMvbWFyc2hhbGxlci9qc29uL1JlY29yZE1hcnNoYWxsZXIuamF2YQ==) | 81.8182% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16414?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...erters/src/main/groovy/grails/converters/JSON.java](https://app.codecov.io/gh/apache/grails-core/pull/16414?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Fgrails%2Fconverters%2FJSON.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L2dyYWlscy9jb252ZXJ0ZXJzL0pTT04uamF2YQ==) | 91.6667% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16414?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...verters/marshaller/json/DomainClassMarshaller.java](https://app.codecov.io/gh/apache/grails-core/pull/16414?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fconverters%2Fmarshaller%2Fjson%2FDomainClassMarshaller.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2NvbnZlcnRlcnMvbWFyc2hhbGxlci9qc29uL0RvbWFpbkNsYXNzTWFyc2hhbGxlci5qYXZh) | 0.0000% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16414?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ng/converters/Jsr310ConvertersConfiguration.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16414?src=pr&el=tree&filepath=grails-databinding%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fdatabinding%2Fconverters%2FJsr310ConvertersConfiguration.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWRhdGFiaW5kaW5nL3NyYy9tYWluL2dyb292eS9vcmcvZ3JhaWxzL2RhdGFiaW5kaW5nL2NvbnZlcnRlcnMvSnNyMzEwQ29udmVydGVyc0NvbmZpZ3VyYXRpb24uZ3Jvb3Z5) | 75.0000% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16414?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/grails-core/pull/16414?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## 9.0.x #16414 +/- ## ================================================== + Coverage 57.5121% 57.7307% +0.2186% - Complexity 22929 23059 +130 ================================================== Files 2173 2175 +2 Lines 105157 105353 +196 Branches 18769 18813 +44 ================================================== + Hits 60478 60821 +343 + Misses 36422 36234 -188 - Partials 8257 8298 +41 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/grails-core/pull/16414?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...s/configuration/ConvertersConfigurationHolder.java](https://app.codecov.io/gh/apache/grails-core/pull/16414?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fconverters%2Fconfiguration%2FConvertersConfigurationHolder.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2NvbnZlcnRlcnMvY29uZmlndXJhdGlvbi9Db252ZXJ0ZXJzQ29uZmlndXJhdGlvbkhvbGRlci5qYXZh) | `86.9048% <100.0000%> (+1.0073%)` | :arrow_up: | | [...figuration/ConvertersConfigurationInitializer.java](https://app.codecov.io/gh/apache/grails-core/pull/16414?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fconverters%2Fconfiguration%2FConvertersConfigurationInitializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2NvbnZlcnRlcnMvY29uZmlndXJhdGlvbi9Db252ZXJ0ZXJzQ29uZmlndXJhdGlvbkluaXRpYWxpemVyLmphdmE=) | `89.9160% <100.0000%> (+2.6144%)` | :arrow_up: | | [...ils/web/converters/jackson/HtmlSafeJsonWriter.java](https://app.codecov.io/gh/apache/grails-core/pull/16414?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fconverters%2Fjackson%2FHtmlSafeJsonWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2NvbnZlcnRlcnMvamFja3Nvbi9IdG1sU2FmZUpzb25Xcml0ZXIuamF2YQ==) | `100.0000% <100.0000%> (ø)` | | | [...grails/web/converters/jackson/JsonMapperValue.java](https://app.codecov.io/gh/apache/grails-core/pull/16414?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fconverters%2Fjackson%2FJsonMapperValue.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2NvbnZlcnRlcnMvamFja3Nvbi9Kc29uTWFwcGVyVmFsdWUuamF2YQ==) | `100.0000% <100.0000%> (ø)` | | | [.../converters/jackson/JsonMapperValueMarshaller.java](https://app.codecov.io/gh/apache/grails-core/pull/16414?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fconverters%2Fjackson%2FJsonMapperValueMarshaller.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2NvbnZlcnRlcnMvamFja3Nvbi9Kc29uTWFwcGVyVmFsdWVNYXJzaGFsbGVyLmphdmE=) | `100.0000% <100.0000%> (ø)` | | | [.../web/converters/marshaller/json/MapMarshaller.java](https://app.codecov.io/gh/apache/grails-core/pull/16414?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fconverters%2Fmarshaller%2Fjson%2FMapMarshaller.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2NvbnZlcnRlcnMvbWFyc2hhbGxlci9qc29uL01hcE1hcnNoYWxsZXIuamF2YQ==) | `92.3077% <100.0000%> (ø)` | | | [...converters/marshaller/json/OptionalMarshaller.java](https://app.codecov.io/gh/apache/grails-core/pull/16414?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fconverters%2Fmarshaller%2Fjson%2FOptionalMarshaller.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2NvbnZlcnRlcnMvbWFyc2hhbGxlci9qc29uL09wdGlvbmFsTWFyc2hhbGxlci5qYXZh) | `100.0000% <100.0000%> (ø)` | | | [...ing/converters/DefaultConvertersConfiguration.java](https://app.codecov.io/gh/apache/grails-core/pull/16414?src=pr&el=tree&filepath=grails-databinding%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fdatabinding%2Fconverters%2FDefaultConvertersConfiguration.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWRhdGFiaW5kaW5nL3NyYy9tYWluL2dyb292eS9vcmcvZ3JhaWxzL2RhdGFiaW5kaW5nL2NvbnZlcnRlcnMvRGVmYXVsdENvbnZlcnRlcnNDb25maWd1cmF0aW9uLmphdmE=) | `100.0000% <100.0000%> (ø)` | | | [...erters/src/main/groovy/grails/converters/JSON.java](https://app.codecov.io/gh/apache/grails-core/pull/16414?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Fgrails%2Fconverters%2FJSON.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L2dyYWlscy9jb252ZXJ0ZXJzL0pTT04uamF2YQ==) | `54.4803% <91.6667%> (+29.2095%)` | :arrow_up: | | [...verters/marshaller/json/DomainClassMarshaller.java](https://app.codecov.io/gh/apache/grails-core/pull/16414?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fconverters%2Fmarshaller%2Fjson%2FDomainClassMarshaller.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2NvbnZlcnRlcnMvbWFyc2hhbGxlci9qc29uL0RvbWFpbkNsYXNzTWFyc2hhbGxlci5qYXZh) | `45.9259% <0.0000%> (ø)` | | | ... and [5 more](https://app.codecov.io/gh/apache/grails-core/pull/16414?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | ... and [21 files with indirect coverage changes](https://app.codecov.io/gh/apache/grails-core/pull/16414/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
