jdaugherty commented on PR #16415:
URL: https://github.com/apache/grails-core/pull/16415#issuecomment-5874853250
@codeconsole can you please fix your merge conflict and confirm the test
isn't a real failure?
The failed test is ErrorsFunctionalSpec › "Test Interceptor.afterView() has
access to the exception if thrown", in the Hibernate 7 app1 example. It failed
for real (no retry passed, despite the "all tests passed" heading), but it's
unrelated to this PR:
- It's a timing race. The interceptor's afterView() sets a System property
after the error page has already gone to the browser, so the test can check
before it's set.
- The PR doesn't touch Hibernate, interceptors or any web code.
Assuming it's not a real failure, I'm good to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
